BillyGalbreath / Pl3xMap

Pl3xMap is a minimalistic and lightweight world map viewer for Minecraft servers using the vanilla Minecraft rendering style
https://modrinth.com/plugin/pl3xmap
MIT License
3 stars 4 forks source link

Thinking about Folia? #145

Closed xiaoyueyoqwq closed 1 year ago

xiaoyueyoqwq commented 1 year ago

I see that the squaremap is already adapted to Folia, but I think Pl3xmap does a lot better than the squaremap in some aspects, do you consider adapting Folia?

BillyGalbreath commented 1 year ago

Does folia not run Bukkit plugins? There shouldn't be anything to do to work on folia, afaik.

JasperTheMinecraftDev commented 1 year ago

It has a very different API so no.

Roan-V commented 1 year ago

https://github.com/PaperMC/Folia#the-new-rules :)

BillyGalbreath commented 1 year ago

https://github.com/PaperMC/Folia#the-new-rules

Huh, well v3 doesn't use any of the Bukkit API that wouldn't be thread safe already, so it should "just work".

I'll add that to the plugin.yml later tonight and see if anything blows up.

JasperTheMinecraftDev commented 1 year ago

Good idea, recommend reading the page first though. There are some things that are entirely broken.

BillyGalbreath commented 1 year ago

Had to add in a main tick heartbeat since folia doesnt seem to have one, but preliminary testing of v3 on folia looks good. I dont have a busy server to really test it on, though. Good luck ^_^

Implemented as of build 349 https://github.com/BillyGalbreath/Pl3xMap/commit/f62937d00426dc225adb467e207a3c504550823b

xiaoyueyoqwq commented 1 year ago

Had to add in a main tick heartbeat since folia doesnt seem to have one, but preliminary testing of v3 on folia looks good. I dont have a busy server to really test it on, though. Good luck ^_^

Implemented as of build 349 f62937d

I think you should have the right person - I am the administrator of this kind of server ;) Well, if there is a problem, I will continue to open an issue to provide feedback, and finally thank you for your dedication to the Folia server