Closed hextraza closed 1 week ago
Also, we should target 23.11 so we can deploy to mGAP now.
@hextraza: this seems fine, but one question. if we're going to treat every int field like a long (which is what i think this does), should the DISCVRseq code index every INT as a LONG: https://github.com/BimberLab/DISCVRSeq/blob/dc81abc6b8e9ae2936415145c7d76dccdca6f2e9/src/main/java/com/github/discvrseq/walkers/VcfToLuceneIndexer.java#L443. If I understand it, we are indexing genomicPosition as LONG, but everything else as INT
the line targets numericQueryParserFields which is only used to look up the type of sorting fields-- all sorting fields are indexed as 64 bit long in DiscvrSeq. actual values displayed in the table are all parsed as ints, instead. if we wanted to display genomicPosition it'd have to be parsed in the API as a long instead of as an int, but it isn't a value displayed on the client side afaik
I can rebase this on 23.11.
@hextraza: this seems fine, but one question. if we're going to treat every int field like a long (which is what i think this does), should the DISCVRseq code index every INT as a LONG: https://github.com/BimberLab/DISCVRSeq/blob/dc81abc6b8e9ae2936415145c7d76dccdca6f2e9/src/main/java/com/github/discvrseq/walkers/VcfToLuceneIndexer.java#L443. If I understand it, we are indexing genomicPosition as LONG, but everything else as INT