BimmerGestalt / AAIdrive

Implementations of some Android Auto features as unofficial IDrive apps
MIT License
547 stars 90 forks source link

Add a UI to choose apps to trigger notification alerts #119

Open hufman opened 4 years ago

hufman commented 4 years ago

A UI should be added to allow users to customize the notification behavior for new notifications, mainly which apps should be alerted about,

RMe588 commented 3 years ago

If you have time, can you also look into the closing behaviour of new notifications. Some notifications automatically close after some seconds, others need to be closed by the "back" button. Would be nice to select if notifications should close after n time or not.

hufman commented 3 years ago

Can you provide examples of the types of notifications that you'd want to change the behavior for? I'd like to incorporate heuristics to pick the right choice by default, instead of requiring you edit a UI to get sensible behavior.

jezikk82 commented 3 years ago

I'd like to see 2 small enhancements:

- choose which app can forward notifications to system Notification Center
- customization of the icon presented in car and link it to apps. (interesting because I see in my I drive with Office functions couple of icons related to notifications, try to catch them by photo to show, but it's for missed call, 2 different for SMS and Mail, Calendar events)

My proposition of apps should be:

hufman commented 3 years ago

Based on the existing logic, the current rules are to popup all notifications that are

I think navigation apps (Maps, Yanosik) are currently suppressed because of the swiping, and I would like to fix it to popup the Maps' navigation prompts for example. Especially after figuring out popups on ID5, which can have a picture. The other categories you've mentioned should already popup, is that not the case?

The code has logic to not popup notifications that are configured in the Android Settings to be silent, but perhaps that needs tuning. Do you have a scenario that isn't working as expected? Do you want to customize it so that some notifications don't popup on the phone but do popup in the car, or vice versa?

What are some examples of popups that you think behaved incorrectly?

jezikk82 commented 3 years ago

Now all notifications works great, but as I mentioned in the SMS&notification app you can configure which apps can trigger notification in notification center. Now all the app shows notification in notification center, but I'd like to have possibility to customize list of apps that can trigger that. So I put a possible groups of apps that should be allowed to show notification in car's notification center + possibility to define custom list.

RMe588 commented 3 years ago

I would like to see some change in the behavior for e.g. Outlook calendar reminders. When you would have a reminder set on 15min before the event you would get a notification in your iDrive at 15 min prior to the event. You can accept this in the iDrive but every minute it will pop up again until the start of the event. A onetime reminder would be suffcient. Another example would be when using Flitsmeister, this app would benefit from notifications that will accept themselves after about 10/15 seconds.

hufman commented 3 years ago

I don't have the bandwidth to work on this presently, and will have to deprioritize it for now to unblock the next release.

jezikk82 commented 3 years ago

Can you guid me where to start investigation about notification customisation per app as mentioned above.

hufman commented 3 years ago

It's a big task with several components:

The Android Architecture Components (with View/ViewModel/Controller pattern) makes it easier to split up development among different people. Someone could create UI design mockups, someone could build a matching mock UI that calls methods on a controller to manipulate the override options on a simple in-memory viewmodel, and then someone else could swap that controller and viewmodel for one that uses a configuration storage, and then the modifications on the car side are straight-forward. Until I can devote time to work on it, I welcome contributions of any variety!

bogdan-calapod commented 3 years ago

Hey :D I could help with the UI part, even draw up the activity XML (if generating it via Android Studio's designer is okay)