BimmerGestalt / AAIdrive

Implementations of some Android Auto features as unofficial IDrive apps
MIT License
541 stars 90 forks source link

Spotify Navigate menu #549

Closed KdiKomunismo closed 2 years ago

KdiKomunismo commented 2 years ago

Hi there, in the last update (1.3.2-77) Spotify Navigate menu changed in a way that makes it impossible to find your library. I'm using Spotify last version (8.7.8. 1206) on a Mi 9t, and a 2017 bmw 418d with id5

hufman commented 2 years ago

Hmmm there haven't been any changes in that section of code for a while, can you share a screenshot or video that demonstrates the issue you are seeing?

KdiKomunismo commented 2 years ago

Sure, here is a link to a video I made. https://photos.app.goo.gl/u836YAP2iYXSABod9

Until Friday in the first level of the Navigate menu I had 4 entries, which I don't remember exactly, but one of them was My library, and another one gave me access to the same playlist categories I normally see in the search section of the mobile app of Spotify

hufman commented 2 years ago

Interesting! Mine doesn't show a change (you can test without going out to the car by clicking the Spotify icon in the Music app of the phone UI). What version of Spotify are you using, and do you have Spotify Premium? My Spotify Premium on version 8.5.72.800 shows the expected entries (Recently Played, Your Library, Browse).

TBGR commented 2 years ago

I see this new behavior when I haven't connected the phone to my hotspot.

KdiKomunismo commented 2 years ago

Interesting! Mine doesn't show a change (you can test without going out to the car by clicking the Spotify icon in the Music app of the phone UI). What version of Spotify are you using, and do you have Spotify Premium? My Spotify Premium on version 8.5.72.800 shows the expected entries (Recently Played, Your Library, Browse).

I see the same in the music app (see attachment). I have Spotify premium, version 8.7.8.1206

IMG_20220307_223950

JutPie commented 2 years ago

Same here with the newest builds. I went back to version: 1.3.1-88-d9d74cb 14.01.2022 17:25:02.

Here I have the "old" menu.

Screenshot_20220307-230152_AAIdrive

hufman commented 2 years ago

That's very curious, because the last change to any of the music app logic (such as the Spotify api) was January 13, and so reverting the version should not have mattered. I'll watch to see if my Spotify updates to this new 8.7 version soon so I can see what's going on!

daniel1v commented 2 years ago

I am experiencing the same issue with the latest nightly of aai and Spotify 8.7.10.1262.

Swithing to the official Playstore version of aai solves the issue for me. Installing the latest nightly again, brings also up the issue again. I double checked that behavior and I was always connected to the internet.

So from my point the only logical conclusion is that the issue must be caused by changes between the Playstore version and the latest nightly and is also independent from internet connection.

Unfortunately I cannot say, when this started, because I did not use aai for several weeks. The oldest apk I could find, is from February 22, where the issue also exists.

DominikS66 commented 2 years ago

Same problem here. I will test different versions.

KdiKomunismo commented 2 years ago

Don't know if it's related, but I'm also noticing way more disconnections than before. I usually had one or two disconnections every couple of hours, now I have 5-6 in the same time

hufman commented 2 years ago

I'm very confused on why switching the version of AAIdrive would change anything. The current production Play Store release is built from bd04b8e from Feb9 (the beta version is 9e14a19 from March2), which both were after any change to the music code on January 13 and definitely after any Spotify-specific changes on December 22nd. Of course you should check what version you see in the Support tab, but those should be the expected versions. My guess is that uninstalling and reinstalling resets some cache that Spotify provides (AAIdrive itself does not have any browse caching). The Play Store and Github versions have different signing keys, and perhaps Spotify is caching based on that key. I wonder if they changed the name of the root directory? The code currently requests default-cars, which no longer appears in the list of options. Trying out some of the new values (against my 8.5.72 Spotify version) has some interesting results:

I think Spotify has removed this default-cars root directory from the new version, and so we'll have to hardcode the desired entries in the root. In my browse, the default-cars returned the entries [com.spotify.recently-played, com.spotify.your-library, com.spotify.browse], so it should be doable to slip those into the results (perhaps added to the default list with its other quick access results.

hufman commented 2 years ago

Please try out this test build of this branch. It works for me, and I just want confirmation that it works for you before I merge it!

JutPie commented 2 years ago

Can't test while in car, but in App for me it shows the "new" browsing menu.

Screenshot_20220312-214914_AAIdrive

But by the way I really love this app and appreciate your work 👍

hufman commented 2 years ago

Perfect, thank you so much!

KdiKomunismo commented 2 years ago

I'm also trying without the car, but it works like a charm Screenshot_2022-03-13-00-17-14-706_me hufman androidautoidrive

hufman commented 2 years ago

Excellent! It's now merged to the main Github build, and so I'll let it sit for a few days to get translated before pushing it out the store.