Ignore unplayable songs when fetching playlists from spotify

[NavjotPanesar]

• Problem: When unplayable songs are in the queue, the Spotify remote app and the Spotify web API don't seem to agree on song indexing
• Fix: Ignore unplayable songs when fetching from the Spotify web API
• Details:
  • We need to provide the user's Market locale. When we do, Spotify will let us know whether the song is playable or not
    • As a side effect I had to add a new scope to the Spotify Authorization to allow us to pass "FROM_TOKEN" as the Market. AFAIK we don't actually fetch new data from the user, this string gets passed through to the Spotify web api and the API is smart enough to fetch the Market for the current user. We do require this scope though for the API to provide that functionality.
    • Now that we have provided the Market field, we can filter out songs that are unplayable by inspecting the field from the Spotify web api response.

Associated issue: https://github.com/BimmerGestalt/AAIdrive/issues/291

[codecov-commenter]

Codecov Report

Merging #579 (f0f146e) into main (5d5d9f9) will decrease coverage by 7.82%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #579      +/-   ##
============================================
- Coverage     49.42%   41.60%   -7.83%     
+ Complexity     1789     1421     -368     
============================================
  Files           249      242       -7     
  Lines         11792    11355     -437     
  Branches       2331     2266      -65     
============================================
- Hits           5828     4724    -1104     
- Misses         4826     5634     +808     
+ Partials       1138      997     -141     

Impacted Files	Coverage Δ
...n/androidautoidrive/music/spotify/SpotifyWebApi.kt	32.46% <0.00%> (+1.73%)	:arrow_up:
...autoidrive/phoneui/SpotifyAuthorizationActivity.kt	0.00% <0.00%> (ø)
...droidautoidrive/phoneui/viewmodels/MapPageModel.kt	0.00% <0.00%> (-100.00%)	:arrow_down:
...idautoidrive/phoneui/fragments/MapsPageFragment.kt	0.00% <0.00%> (-100.00%)	:arrow_down:
...dautoidrive/phoneui/fragments/MusicPageFragment.kt	0.00% <0.00%> (-100.00%)	:arrow_down:
...dautoidrive/phoneui/viewmodels/SupportPageModel.kt	0.00% <0.00%> (-100.00%)	:arrow_down:
...autoidrive/phoneui/fragments/CarSummaryFragment.kt	0.00% <0.00%> (-100.00%)	:arrow_down:
...utoidrive/phoneui/fragments/SupportPageFragment.kt	0.00% <0.00%> (-100.00%)	:arrow_down:
...toidrive/phoneui/fragments/CalendarPageFragment.kt	0.00% <0.00%> (-100.00%)	:arrow_down:
...toidrive/phoneui/fragments/OverviewPageFragment.kt	0.00% <0.00%> (-100.00%)	:arrow_down:
... and 86 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d5d9f9...f0f146e. Read the comment docs.

[hufman]

This is wonderful, it looks so elegant! I'll have to try it out when I get back to my development system :) Thank you so much!

[hufman]

Thank you so much!

[NavjotPanesar]

thank you for building this in the first place! It's really upgraded the experience of using my car on a daily basis. looking forward to help out where I can.

[NavjotPanesar]

@hufman just wondering what the nightly builds process is like, will the build that is hyperlinked in the readme be updated tonight off of main ?

[hufman]

That "nightly build" is technically updated as soon as this build step finishes. It takes about 30 minutes so I call it nightly, but this fix is already included in the current build :)

[hufman]

Also, I pushed this fix to the beta channel in the Play Store!