BimmerGestalt / AAIdrive

Implementations of some Android Auto features as unofficial IDrive apps
MIT License
547 stars 90 forks source link

Latest Beta Version Depends on My BMW from US #694

Closed my-ix closed 1 year ago

my-ix commented 1 year ago

Hi, I am from Malaysia and have My BMW application installed to be proxy for this application to run, unfortunately, it keeps on asking to install My BMW from Play Store which opens other country which I am not able to download, I suspect it's US

hufman commented 1 year ago

Nothing in AAIdrive's MyBMW detection should have changed in the last year or so. Can you share the Play Store link or the package name of your installed MyBMW application, perhaps AAIdrive isn't detecting it properly? AAIdrive only links to the US version because it thinks your phone is US, by default it links to the European version.

my-ix commented 1 year ago

Hi,

It's within your mobile application, clicking will try to open https://play.google.com/store/apps/details?id=de.bmw.connected.mobile20.na

Even I already have installed: https://play.google.com/store/apps/details?id=de.bmw.connected.mobile20.row

I am not sure what's the difference between .na and .row

hufman commented 1 year ago

That's the difference (North America vs Rest Of World). I'm puzzled, because AAIdrive has many more European users than American users and you are only the second person to notice a problem. What version of MyBMW do you have? I see 3.3.1 in the store, and the same version in America.

hufman commented 1 year ago

What happens if you have both the European MyBMW and the European MINI app or the European Supra app installed? AAIdrive just needs to load the security module from one of them, doesn't matter which, and it doesn't care which app provides the connection to the car.

my-ix commented 1 year ago

Hi,

I am able to install both MyBMW and MINI app, but not Supra app due to country restriction similar with the link to install MyBMW within your app.

Even when I have both of them installed, your app still require me to install the different country's MyBMW.

my-ix commented 1 year ago

That's the difference (North America vs Rest Of World). I'm puzzled, because AAIdrive has many more European users than American users and you are only the second person to notice a problem. What version of MyBMW do you have? I see 3.3.1 in the store, and the same version in America.

Both of those links are pointing to the same version which is 3.3.1

galenzhao commented 1 year ago

does it support Chinese ver? our app is:de.bmw.connected.mobile20.cn

hufman commented 1 year ago

If AAIdrive says it can connect to any car (even Mini), it has found the security service and will work with your MyBMW connection. Does it say it is ready to connect to Mini with the Mini app installed?

hufman commented 1 year ago

AAIdrive does not know about the Chinese version, thank you for the pointer! It should be easy enough to add support for it. Until then, you should install (perhaps manually) the US or European version of MyBMW/Mini/Supra app to get the security service (and AAIdrive should say it is ready to connect), and then AAIdrive should connect through the Chinese MyBMW's connection to the car.

galenzhao commented 1 year ago

Hi, the app seems has some problem on bmwapp detection. I installed the following apps, downloaded from external readme.md.

1|ruby:/ $ pm list packages|grep bmw package:de.bmw.connected.mobile20.cn package:de.bmw.connected.mobile20.na package:de.bmw.connected.mobile20.row package:de.bmw.connected.na ruby:/ $

But aaidrive can not detect it sometimes.

galenzhao commented 1 year ago

Screenshot_2023-05-04-10-42-50-948_me hufman androidautoidrive

galenzhao commented 1 year ago

That's the difference (North America vs Rest Of World). I'm puzzled, because AAIdrive has many more European users than American users and you are only the second person to notice a problem. What version of MyBMW do you have? I see 3.3.1 in the store, and the same version in America.

Both of those links are pointing to the same version which is 3.3.1

Could you check your phone settings. Maybe you set your location to US.

I checked aaidrive code. It using system settings to determine which bmw app should installed,and it maybe not same region with gplay.

hufman commented 1 year ago

Thanks for making me test it out and helping find the bug! AAIdrive was never updating the BMW installation status in the UI after the initial draw, even after the async connection happened. Please test the latest build which should fix this, and also add support for the Chinese MyBMW app.

my-ix commented 1 year ago

I am still having problem, because the link from this application still pointing to a version that is not available in the country that I am residing.

Screenshot_20230505_152543

hufman commented 1 year ago

AAIdrive picks the US version if the phone's locale is set to US, otherwise it defaults to the Rest of World version. What locale is your phone set to?

my-ix commented 1 year ago

Hi,

I don't have any problem installing any application, I set my phone to use US as locale, and country is Malaysia.

I suggest the application to just check any of My BMW installed, why in the first place what to lock that?

hufman commented 1 year ago

AAIdrive does check if any MyBMW is installed, and as of the latest build (and the latest Play Store beta) it will even properly show that it found it. The connection logic still worked, even though the UI was prompting to install MyBMW, but now it will know that it's already installed and not prompt.