BimmerGestalt / AAIdrive

Implementations of some Android Auto features as unofficial IDrive apps
MIT License
531 stars 89 forks source link

Carinfo extension #710

Closed DominikS66 closed 1 year ago

DominikS66 commented 1 year ago

Added/changed various items in iDrive cardata display (advanced) -engine torque -climate evaporator temp -climate compressor state and level -GPS speed -additional information display with air conditioning data changes: -various translations (GPS data, directions, Window state...)

codecov-commenter commented 1 year ago

Codecov Report

Merging #710 (e10f603) into main (7cece39) will increase coverage by 36.58%. The diff coverage is 80.89%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/710/graphs/tree.svg?width=650&height=150&src=pr&token=CbUKVyqYmJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #710 +/- ## ============================================= + Coverage 16.07% 52.66% +36.58% - Complexity 525 1945 +1420 ============================================= Files 248 254 +6 Lines 13263 13678 +415 Branches 2397 2448 +51 ============================================= + Hits 2132 7203 +5071 + Misses 10873 5265 -5608 - Partials 258 1210 +952 ``` | [Impacted Files](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [...java/me/hufman/androidautoidrive/CarInformation.kt](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBwL3NyYy9tYWluL2phdmEvbWUvaHVmbWFuL2FuZHJvaWRhdXRvaWRyaXZlL0NhckluZm9ybWF0aW9uLmt0) | `83.87% <0.00%> (+35.90%)` | :arrow_up: | | [...drive/phoneui/fragments/CarAdvancedInfoFragment.kt](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBwL3NyYy9tYWluL2phdmEvbWUvaHVmbWFuL2FuZHJvaWRhdXRvaWRyaXZlL3Bob25ldWkvZnJhZ21lbnRzL0NhckFkdmFuY2VkSW5mb0ZyYWdtZW50Lmt0) | `0.00% <0.00%> (ø)` | | | [...java/me/hufman/androidautoidrive/cds/CDSMetrics.kt](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBwL3NyYy9tYWluL2phdmEvbWUvaHVmbWFuL2FuZHJvaWRhdXRvaWRyaXZlL2Nkcy9DRFNNZXRyaWNzLmt0) | `56.29% <44.44%> (+56.29%)` | :arrow_up: | | [...ndroidautoidrive/carapp/carinfo/CarDetailedInfo.kt](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBwL3NyYy9tYWluL2phdmEvbWUvaHVmbWFuL2FuZHJvaWRhdXRvaWRyaXZlL2NhcmFwcC9jYXJpbmZvL0NhckRldGFpbGVkSW5mby5rdA==) | `75.53% <91.89%> (+75.53%)` | :arrow_up: | | [.../main/java/me/hufman/androidautoidrive/carapp/L.kt](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBwL3NyYy9tYWluL2phdmEvbWUvaHVmbWFuL2FuZHJvaWRhdXRvaWRyaXZlL2NhcmFwcC9MLmt0) | `86.50% <100.00%> (+86.50%)` | :arrow_up: | ... and [124 files with indirect coverage changes](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/710/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/710?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/710?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [7cece39...e10f603](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/710?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).
DominikS66 commented 1 year ago

Some displays: Air condition info: 20230608_132103 GPS data: 20230608_132054 driving data: 20230608_132044 Tested on 2019 BMW F20, NBT entrynav2 with retrofited 8.8" display

Bushido1992 commented 1 year ago

if it´s possible, i have some other ideas: (i got an ak-motion data display on my old car, this inspired me)

Layout


-motor temp -actual PS (as on sportdisplay)
-oil -actual NM (as on sportdisplay) -intake air temperature - exhaust temp
-battry percent -current Battery Voltage


other ideas:, oil pressure, rail pressure

Switch Temperatures to a own menu

in out hvac

DominikS66 commented 1 year ago

@Bushido1992 only values, which are available through BMW connected Interface, can be shown here. Have a Look at https://bimmergestalt.github.io/BMWConnectedAnalysis/cds/ for an overview. I already have implemented the most useful items I‘ve found inside this table. If you think there should be other items from this table-let us know.

Bushido1992 commented 1 year ago

@DominikS66 thanks for the Info, I did not know that. I will look into it

hufman commented 1 year ago

Ok, I merged the Sport Display PR, ready for you to rebase or merge to resolve the conflicts!

DominikS66 commented 1 year ago

Merged. Changed to Sports Display, in Advanved mode, my version is shown.

Bushido1992 commented 1 year ago

Hey, with this Pull i have an issue. When i'm on gps data and switch as example to sport display and then back to gps data on the bottom the left and right values are then from the latest Menu Screenshot_20230626_094858_Gallery

And for the Climate Menu... If its not better to put the compressor state to the right side? I think right side is better as undeaneath. At least in my opinion

hufman commented 1 year ago

An interesting side-effect! The car doesn't natively clear the pages when switching, because it just sees that the table is the same 5 rows high. The bottom row of the GPS page only shows the GPS Speed, and you were probably safely parked and so this cell wasn't updating to clear the previous page's data. I'll work on making it clear the data better when switching pages.