Couple of Bugs

[Maxetto]

- UPDATED x2 -

Hi, I'm testing this plugin, however in the last version v1.4.0 there are a couple of Bugs, some are Major, others are just minimal.

• [x] 13b) Golden Apples can be eaten if full life and gives normal Golden Apple buffs.
• [ ] 17) --Feature Request-- Zombie spawned at game start gets a different Kit than the default one if he has not selected another.
• [ ] 21) Regeneration Potion doesn't regen Health (Confirmed caused by Infected to work with Food Healing).
• [ ] 24) --Feature Request-- Configurable Wait Time before Game Start (after voting phase) and after Game End (before teleporting back to Lobby).
• [x] 25) --Feature Request-- Transfer Potions to self and allies and, if not already, possibility to transfer more than 1 potion after hit (Like this)
• [x] 27) --Feature Request-- Option to make KillStreaks for Infecteds stay after death. (As it's not likely that Infecteds can get high KillStreaks compared to Humans) (Broken in latest version)
• [x] 29) Random function for first spawn should be unique, meaning it there are less people than spawn points, they should spawn in a different spawn point.
• [x] 35) Kits (also default ones from a fresh config) lost Icon and Armor settings. It's impossible to set them as for now.
• [x] 46) Many things still needs to be translatable.

Thank you for this awesome plugin, hope to see it getting better and better over time.

Using: Paper 1.8.8 BimmCore v0.0.10 McInfected v1.5.8 McInfected-Ranks v1.2.9 McInfected-Dedicated v0.1.7 McInfected-LobbyItems v0.1.1 Vault v1.5.6 LuckPerms v5.0.72 iDisguise v5.8.2 CrackShot v0.98.5 ProtocolLib v4.5.0 EssentialsX v2.17.2.3

[Bimmr]

Glad to see that someone knows how to make a bug ticket :laughing:, I've had way to many people just make a ticket that says "This doesn't work" then doesn't post any more info.

I'll start looking into them.

1. Can I see your setup for that killstreak(So I can see exactly how the command is written)
2. Are you using a book or a book and quill? On my test server I have it running Spigot 1.8.8 and the book and quill work fine.
3. Not to sure what you mean? Do the messages display more than once?
4. I decided to let Crackshot handle grenades because that plugin was coded with guns and grenades in mind as where McInfected wasn't.

[Bimmr]

1. For a quick fix change "item:" to "id:". I will fix it in the next version.
2. Normally when I see that invalid book tag it was when I was playing on my friends server and I had a written book on a 1.8 server that had just recently updated from 1.7.10
3. I need this here to make the next number say 4....
4. You can use "gun:" to give a class a grenade

[Bimmr]

9, It may be a bug with crackshot but I'll look into it.

10, The compass is meant to be just a ping to show their last known location.

11, I don't think there is a type modifier for items, you're best bet is just to make a custom potion

12, I am in the process of adding an unbreakable modifier.

13, I'll make it so golden apples heal you to full because that sounds like a good idea, but I'm not able to make it give the effects because of the way the food healing system works.

[Bimmr]

Just a list of everything in this ticket

• [x] Use Global permissions instead of per world
• [x] Killstreaks aren't working for the tag "item:"
• [x] Older versions of Spigot don't have Cooked Mutton in the material enum
• [x] Books don't work with Carbon trying to update from 1.7.10 to 1.8
• [x] Kit and map selection messages appear twice
• [x] Admin commands don't work from console
• [x] McInfected-Dedicated's messages reset on restart
• [x] Crackshot grenades don't work
• [x] Add an unbreakable modifier
• [x] Golden Apples & God Apples heal to max health

[Bimmr]

Does it teleport the player at all or do they just stay at spawn?

[Bimmr]

Are they using a command to leave?

[Bimmr]

While looking at the Crackshot bug i remembered I made a ticket on crackshot. So it looks like the author hasn't fixed the grenade bug. http://dev.bukkit.org/bukkit-plugins/crackshot/tickets/294-weapon-damage-entity-event-and-explosion_no_damage/

[Bimmr]

I dont edit fall damage done to players. On Feb 15, 2016 6:03 PM, "Maxetto" notifications@github.com wrote:

Another thing, this plugin seems to edit fall damage, which causes NoCheatPlus to behave strangely. Expecially if you jump on a water block (only 1 layer, nothing under) from a certain height (2-3, don't remember), you'll get pushed back in the water, allowing you to swim without issues (while instead you should fall under the map and die).

Using: NoCheatPlus #928 http://ci.md-5.net/job/NoCheatPlus/928/

— Reply to this email directly or view it on GitHub https://github.com/Bimmr/McInfected/issues/72#issuecomment-184434216.

[Maxetto]

• [ ] 21) Regeneration Potion doesn't regen Health.
• [ ] 24) --Feature Request-- Configurable Wait Time before Game Start (after voting phase) and after Game End (before teleporting back to Lobby).
• [x] 25) --Feature Request-- Transfer Potions to self and allies and, if not already, possibility to transfer more than 1 potion after hit (Like this)
• [x] 27) --Feature Request-- Option to make KillStreaks for Infecteds stay after death. (As it's not likely that Infecteds can get high KillStreaks compared to Humans)
• [x] 29) First Spawn spawns everyone in only one spawn even if more than 1 are configured.

Kits.yml

• [x] EDIT: This is not really a Bug with McInfected, but I suggest you to set Ranks varchar(20) to something like varchar(30) or more. I had to set it to 25 because one of my rank had 24 characters.

[Bimmr]

18) Can I see the error log 20) Why do you have multiple potions in a single slot anyways... 31) I don't edit the damage an arrow does, so It might be another plugin 32) I don't really see why you'd want to disguise as a baby though....

[Maxetto]

18) Error Logs are reachable from "crashes" and "error" words. 20) Probably comfort, I didn't want potions to fill the Hotbar. 31) Will investigate more... 32) High Speed, Low Damage and Armor Baby Zombie Kit.

[Bimmr]

18) Sorry, had something enabled in my web browser which made links not look like links...

[Maxetto]

Ticket cleaned and updated.

Many of the new Bugs (starting from 34°) (such as Lib's Disguises compatibility) are absolutely Major issues.

[Bimmr]

Add the tag "unbreakable" to an item, and i completely forgot about the voting bug I'll be fixing up the Wiki page to show all the tags in a few days.

[Bimmr]

45) Is a YAML limitation, try : or /:

[Maxetto]

45) Doesn't work neither with \:, /:, \u003a, &#(without this here)58;.

[Bimmr]

MySQL is one of the things i forgot to test before uploading, turns out SQL was completely broken for one of McInfected's addons aswell.

[Maxetto]

Ticket updated again. Stated some priorities: Strikethrough: Tested and fixed Bold: High Priority - Game Breaking issues. Italic: Normal Priority - Issues that needs to be fixed but are not that important. Normal Text: Low Priority - Awaiting confirmation, low priority issues or feature requests.

[Bimmr]

I seem to be able to set the icon for the kits, as well as armor seems to be working for me.

[Maxetto]

I can set the Icon for Kits too, but after I load the plugin, they get away from the Kits.yml.

I think the same thing happens to Armor too.

Here are my Config and Kits (Kits are from before the upgrade): config.txt Kits.txt

[Bimmr]

http://img.prntscr.com/img?url=http://i.imgur.com/zVhVSI4.png

The icons are still there after the server has been restarted a bunch of times. I'll test it with your Kits.yml though

[Bimmr]

Only thing I noticed is that the glow doesn't show.

[Maxetto]

After the conversion the Kits.yml breaks and removes "Icon:", "Helmet:", "Chestplate:", "Leggings:" and "Boots:" lines. No matter how I try to put them, they always get removed after the Kit loads (but they work). It does not break if I write them without the "Icon:", "Helmet:", etc. markers (but they don't work). Glow works fine for me. Armor and Icons work until you restart the server or reload the plugin.

May it be caused by Spigot version or one of yours extensions (Versions used are written in the first post)?

EDIT: Also still, problems with MySQL: http://pastebin.com/BKsmZbQW

[Bimmr]

Try removing LibsDisguise off the server then tell me if armor is still broken, because it looks like LibsDisguise will remove the armor, but still apply the protection when hit.

[Maxetto]

Besides that Lib's Disguises isn't working with latest versions of McInfected, it's not a problem with it because armor and icon datas are removed from the Kits.yml

[Bimmr]

They aren't being removed from the file for me. So I really don't know what to do/say, and just to double check, you are using the latest mcInfected and addons as well as bimmcore? On May 21, 2016 9:48 AM, "Maxetto" notifications@github.com wrote:

Besides that Lib's Disguises isn't working with latest versions of McInfected, it's not a problem with it because armor and icon datas are removed from the Kits.yml

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/Bimmr/McInfected/issues/72#issuecomment-220778742

[Maxetto]

I confirm the versions stated on the first post and I confirmed they are the latest possible to get on 1.8.X

Before updating McInfected to v1.4.X, armor and icons were working fine.

[Bimmr]

I am working on the updates in my free time, because I do not make enough to put a focus on them. But recently I've ran into an issue with my computer that I am trying to fix On Jun 3, 2016 7:53 AM, "Maxetto" notifications@github.com wrote:

Still waiting for at least this fix, I can't even run the test server since the game is broken 😕 [ ] 34) Hook with Lib's Disguises doesn't work with older version of Lib's Disguises (for those still in 1.8.8).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Bimmr/McInfected/issues/72#issuecomment-223559700, or mute the thread https://github.com/notifications/unsubscribe/AE0druwkHsPWIVFDK3YRKm848JOVIgUHks5qIBWwgaJpZM4HZr_m .

[Maxetto]

Updated: Added bug 49 and 50, promoted bug 48 to high priority, updated bug 21 and 29 with more information, marked bug 33 as fixed after some testing.

[DanielMac1]

17) --Feature Request-- Zombie spawned at game start gets a different Kit than the default one if he has not selected another. I want that too!

[Bimmr]

@Maxetto Since you seem to be good at finding bugs in my plugins, would you want to test the new version? I haven't uploaded it because I need to test it still but It's always easier to break it when you get someone else to test it.

[DanielMac1]

Ill test it i found this voting bug when there is more than 16 maps it breaks.

[DanielMac1]

Ill test it i found this voting bug when there is more than 16 maps it breaks.

[Maxetto]

@Bimmr Of course, I'm always up for developer/beta versions. However I'm studying for my final exams, so expect slow or even no updates until 4 July.

[DanielMac1]

Pm me a download :palm_tree:

[Bimmr]

Went to send you both a download then noticed I still had a few things to fix... Just finally getting around to it, so hopefully I'll be able to send the files in a day or two

[Maxetto]

I finished my final exams and I'm finally on Vacation :stuck_out_tongue_closed_eyes: I'm ready to test almost 24/24h 7/7d*.

* Or until my GPU burns out, as it's running at 80°C in IDLE with fans at full speed :stuck_out_tongue_closed_eyes:

[Bimmr]

K, Currently I'm just having trouble finding time to fix a bug that shouldn't be happening at all in the first place (Like all bugs....)

[Maxetto]

The bug forces the software to adapt, evolve into something new because of it. Work around it or work through it. No matter what, it changes. It becomes something new. The next version. The inevitable upgrade.

- Mr. Robot

[Maxetto]

Here are some new bugs from the Testing version:

• [x] Arena name in Scoreboard have "_" instead of Space
• [x] and trimms with more than 11 characters (due to the Spacing before name).
• [x] Changes done to armor don't save inside the Kits.yml file (When you reload/restart the server, changes are gone).
• [ ] Player names that have an underscore ("_") inside get replaced with space :stuck_out_tongue_closed_eyes:
• [x] Title messages are printed twice/seems glitched.
• [ ] Baby Zombie disguise still not works (Disguise: Zombie baby). (Not working on iDisguises, throws error)
• [x] In Lobby and in Pre-Game you can "die" by falling.

Confirmed fixed bugs are striked on the first message. Old fixed bugs are removed.

[Bimmr]

I just realised I sent the BimmCore that had all my Title/BossBar/Scoreboard testing code in it...

[Maxetto]

Feature Request #27 seems implemented in the dev version but It doesn't seem configurable (or at least I didn't check)

[Bimmr]

For the messages with the time variables, I have been debating if switching the Time variables to a BimmCore config is a good idea. It will allow you to only have to change the time variables once for any plugin that uses BimmCore's TimeUtil class.

For the baby disguises, what disguise plugin are you using?

When editing Armor, are you editing the yml file or using the setup command in game?

[Maxetto]

For the Disguises I'm using Lib's Disguises v8.6.8 (for Minecraft 1.8.8/9).

I edit files directly, I never use In-Game configurators.

[Bimmr]

Do you edit the files when the server is running or when it's stopped?

[Maxetto]

Tried both, same result.

When Infected loads the Kits.yml, it change it by removing (but loading correctly) armor settings like "unbreakable", "enchant", etc. I thought when shutting down the server, the file would be saved correctly again (due to the load/save thing I saw in BimmCore code), but I wasn't right. It's like the old issue where Armor and Icon settings weren't saved at all, but now it's only for their settings.

P.S. I Found the BimmCore config with new languages ;)

[Bimmr]

If it was missing the Unbreakable, Flags, and attributes I think i'd know the issue. But if it's also missing enchantment then i'll have to mess around with it.

[Maxetto]

I have tried changing enchantment from full name (like "ENVIRONMENT_PROTECTION") to ID (like "0") and it does not save.

May be caused because there's "unbreakable" tag too. Will try and report in a minute.

EDIT: No, it changes even alone

[Bimmr]

So it's only changing from "enchantment:0" to "enchantment:PROTECTION"?

[Maxetto]

Yeah, it's going back to "enchantment:PROTECTION". It does that with every armor piece, but not items.