Bin4ry / deejayeye-modder

Other
361 stars 144 forks source link

Controller GPS position wobbling with here maps #109

Closed renton82 closed 6 years ago

renton82 commented 6 years ago

Hello, I noticed that my position using here maps on patched DJI go app 4.1.14 wobble... here you are my video : https://youtu.be/XNMn8vIThF4 . I tried with original go app downloaded from play store without here maps service ( I stop it with bk disabler), DJI go app use than Google maps and it hasn't any problems... If also I use litchi, that uses Google maps, works correctly...

Bin4ry commented 6 years ago

Hey, I cannot fix that. This has to be fixed from the official side. If you use the unmodded app with here maps it is the same.

renton82 notifications@github.com schrieb am Sa., 9. Dez. 2017, 16:42:

Hello, I noticed that my position using here maps on patched DJI go app 4.1.14 wobble... here you are my video : https://youtu.be/XNMn8vIThF4 . I tried with original go app downloaded from play store without here maps service ( I stop it with bk disabler), DJI go app use than Google maps and it hasn't any problems... If also I use litchi, that uses Google maps, works correctly...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Bin4ry/deejayeye-modder/issues/109, or mute the thread https://github.com/notifications/unsubscribe-auth/AApiLEzzA2N_0l3nt3fijUWvtf1XK_bwks5s-qplgaJpZM4Q8ImY .

renton82 commented 6 years ago

Yes, I see... Is there a way to patch DJI go 4.1.14 ( latest patchable version for now) , for make it uses Google maps instead of here maps? I don't understand why with official app if I disable here maps service it switches to Google maps and it works, and if I disable here maps service with modded app, it doesn't work...

Bin4ry commented 6 years ago

That is because the signature key which is used to sign the app is changed when you mod it. The Google maps API key is dependent on the app Signature. You can use your own signature key while modding and get an own Google maps API key for your signature key. Then you only need to put your API key into the androidmanifest. It is fairly easy but needs some work from your side. Just Google Google maps API key and follow the instructions how to add your own API key.

renton82 notifications@github.com schrieb am Sa., 9. Dez. 2017, 16:55:

Yes, I see... Is there a way to patch DJI go 4.1.14 ( latest patchable version for now) , for make it uses Google maps instead of here maps? I don't understand why with official app if I disable here maps service it switches to Google maps and it works, and if I disable here maps service with modded app, it doesn't work...

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Bin4ry/deejayeye-modder/issues/109#issuecomment-350479919, or mute the thread https://github.com/notifications/unsubscribe-auth/AApiLNCuk2Ar3YW6X6qv--XwYTaWiYI0ks5s-q1wgaJpZM4Q8ImY .

renton82 commented 6 years ago

Thank you but I don't think i have enough skills to do something like this... I'm not a programmer and I don't know neither where to start from...

Bin4ry commented 6 years ago

Start with Google 😂 you don't need to be a programmer to change a text in the androidmanifest file 😉 you find this file in the decompile_out folder during the mod process. Just create an own key and follow the tutorials Google gives you. It should be fairly easy, or stick to here maps, you should fly anyway and not look on the maps 😉 😂

renton82 notifications@github.com schrieb am Sa., 9. Dez. 2017, 17:02:

Thank you but I don't think i have enough skills to do something like this... I'm not a programmer and I don't know neither where to start from...

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Bin4ry/deejayeye-modder/issues/109#issuecomment-350480811, or mute the thread https://github.com/notifications/unsubscribe-auth/AApiLPqYL8JwoaMis6-fjl5H-YRV8kMiks5s-q74gaJpZM4Q8ImY .

Matioupi commented 6 years ago

A simple way to achieve what you are looking for is to use App Cloner and make a clone of the modded app, it will switch the map engine to Google. You will still have to generate a Google API key for it but this is really straightforward from App Cloner, there is a menu that send you straight to the right Google page. You'll find additionnal info on this doc : https://www.dropbox.com/s/ne4rk6l7dr3qphj/Tutorial%20DJI%20Waypoints%20with%20Spark.pdf?dl=0

I don't know if there are some potential safety/data security/IT threats issues with the cloned app. I've been using it and did not notice anything strange.

Bin4ry commented 6 years ago

One could do it this way to get Google maps working. But please do not install it along with an unmodded app. Only use the modded or unmodded version per device not both :-) I might integrate the key injection to the next major release of the modder

Matioupi notifications@github.com schrieb am Sa., 9. Dez. 2017, 17:12:

A simple way to achieve what you are looking for is to use App Cloner and make a clone of the modded app, it will switch the map engine to Google. You will still have to generate a Google API key for it but this is really straightforward from App Cloner, there is a menu that send you straight to the right Google page. You'll find additionnal info on this doc : https://www.dropbox.com/s/ne4rk6l7dr3qphj/Tutorial%20DJI%20Waypoints%20with%20Spark.pdf?dl=0

I don't know if there are some potential safety/data security/IT threats issues with the cloned app. I've been using it and did not notice anything strange.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Bin4ry/deejayeye-modder/issues/109#issuecomment-350482652, or mute the thread https://github.com/notifications/unsubscribe-auth/AApiLB9g50vKJuGr0KF9KoRubNpvNzeFks5s-rFsgaJpZM4Q8ImY .

renton82 commented 6 years ago

Ok... i obtained google maps api keys but where have i to copy? Here: <meta-data android:name="com.google.android.gms.version" android:value= ? or here: <meta-data android:name="com.google.android.maps.v2.API_KEY" android:value= ?

renton82 commented 6 years ago

I have done with app cloner! Now i have modded 4.1.14 with google maps! I noticed also that original modded 4.1.14 still ask update from playstore even if i selected "remove update force"; i have resolved last one issue with app cloner...

Bin4ry commented 6 years ago

Cool. Thx for reporting. We might add this function in future releases :-)

renton82 notifications@github.com schrieb am So., 10. Dez. 2017, 14:59:

I have done with app cloner! Now i have modded 4.1.14 with google maps! I noticed also that original modded 4.1.14 still ask update from playstore even if i selected "remove update force"; i have resolved last one issue with app cloner...

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Bin4ry/deejayeye-modder/issues/109#issuecomment-350550259, or mute the thread https://github.com/notifications/unsubscribe-auth/AApiLCS87iVykO7ujvdTpTGL5tsSsFEMks5s--OtgaJpZM4Q8ImY .

Matioupi commented 6 years ago

I succeded "cloning" without the cloner, but the maps are not working anymore. We need to check how app cloner "blocks" here maps so that the modded app defaults to Google. By the way, I looked at the cloned/decompiler app, and found that it's adding some extra classes it's adding an axtra lib : libAndHook.so all other lib get modified/patched

I'd really like if we can succeed cloning without all those unknown "extras" and with working maps

renton82 commented 6 years ago

I noticed also that Airdata UAV Sync doesn't work but i don't know if it's because the cloned app or doesn't work also with "original" modded 4.1.14

renton82 commented 6 years ago

Problem solved, i don't know why, but dji v4 folder has been renamed as dji v5...

DamoRSS commented 6 years ago

@renton82 The reason you will have a V5 folder is to make it different to the original stock V4 app folders to allow the stock app and the cloned app to be installed at the same time. But as Bin4ry says.. don't install a modded app at the same time as a stock app :)

renton82 commented 6 years ago

Before installing cloned app i uninstalled "original" app however...

DamoRSS commented 6 years ago

i presume App cloner doesn't know that.. it just changes the folder name by default i guess.

renton82 commented 6 years ago

I presume this so... :-)