search

BinPro / CONCOCT

Clustering cONtigs with COverage and ComposiTion
Other
125 stars 48 forks source link

Arguments not longer used #239

Closed alneberg closed 5 years ago

alneberg commented 5 years ago

The number of iterations given by the user is ignored. So is epsilon. These parameters are rather complex and it might not be necessary to give users access to them. But the current way to handle it is faulty nevertheless.

chrisquince commented 5 years ago

Well this is an easy thing to change as it is all in the python wrapper, let me look at it...

chrisquince commented 5 years ago

No I was wrong those constants are currently hard coded in the C module. I will change that later on today.

alneberg commented 5 years ago

The max iterations parameter is now working again thanks to c21349bdbe68139e82fa81dc7e14e5e8679a72a3. The epsilon parameter is still not useable, but we might as well remove that as an option, I haven't come across any time where this parameter should be adjusted.