BinarCode / laravel-restify

The fastest way to make a powerful JSON:API compatible Rest API with Laravel.
https://restify.binarcode.com
MIT License
602 stars 55 forks source link

Is this package JSON API compatible? #266

Closed martianatwork closed 3 years ago

martianatwork commented 4 years ago

In the documentation you have mentioned:

JSON:API consistency

Maintain your API consistent accordingly with https://jsonapi.org

But it seems like it isn't.

I love the way you have structured this package it is close to Laravel Nova.

binaryk commented 4 years ago

Thanks for the feedback 👍

I'm trying to keep it as close as possible with jsonapi.org standard. Could you provide some example where it doesn't?

martianatwork commented 4 years ago

@binaryk There many things such as:

  1. Filters, Ref: https://jsonapi.org/recommendations/#filtering
  2. Relationships, This package uses with parameter where JSON api uses include there must be many more. I haven't used the package because it isn't fully compatible with JSON api but i love the way it has been implemented. I wish if we could add a support package or combability layer for JSON api.
binaryk commented 4 years ago

Currently we actively work on the 4th version. Thanks for you feedback @martianatwork, we'll pay attention to this part in the new release.

martianatwork commented 4 years ago

@binaryk great, if you need any code contribution let me know. I will be happy to contribute.

binaryk commented 3 years ago

The 5th version has will have json:api filtering. Thank you!