BinarCode / laravel-restify

The fastest way to make a powerful JSON:API compatible Rest API with Laravel.
https://restify.binarcode.com
MIT License
604 stars 54 forks source link

fix: required is not added to rules and rules overriding #567

Closed maicol07 closed 1 year ago

what-the-diff[bot] commented 1 year ago

PR Summary

binaryk commented 1 year ago

Please fix tests and add a unit test that covers this functionality.

Thank you!

maicol07 commented 1 year ago

@binaryk done! However, I don't know where to add a test for this methods (related to rules)

binaryk commented 1 year ago

Thank you for your contribution, however at this point we cannot merge PR's without tests.

More than that, the fluent API should follow the Laravel Nova way, using that method to overwrite rules doesn't feels natural.

maicol07 commented 1 year ago

@binaryk I'll redo the PR with just the fix for the issue without overriding anything

maicol07 commented 1 year ago

The new PR is this one: #575