search

BinarMorker / TimeWastedOnDestiny

http://wastedondestiny.com
GNU General Public License v3.0
23 stars 3 forks source link

Enable cors header for API #35

Closed remybach closed 7 years ago

remybach commented 7 years ago

I hope you don't mind, but I took the liberty of adding what I think is needed for this. My PHP is a bit rusty, and I'm not sure how to test this without putting it live and seeing if it works.

Edit: this is in relation to #34.

BinarMorker commented 7 years ago

Thank you, I don't really have the time to work on the website myself these days.

The change has gone live, so you should be able to try it. I also took the time to fix some priority speed issue on the website and API.

Tell me if it works!

remybach commented 7 years ago

Ah, that's great... thanks so much! I've tested it and it seems to be working now \o/

remybach commented 7 years ago

Just FYI, here's what I created using your API: https://remybach.github.io/destiny-return-on-investment

I'll be posting it on /r/destinythegame in a few hours' time, so I thought I'd give you a heads up 😄

BinarMorker commented 7 years ago

I love it!

That's an awesome website you,ve made. Just for your information, Bungie's API might change with Destiny 2, so I'll try to keep mine as close as possible but I might have to change a couple things. I'll keep you updated and provide you with some documentation if I have to change it.

On Thu, Apr 20, 2017 at 12:03 PM, Rémy Bach notifications@github.com wrote:

Just FYI, here's what I created using your API: https://remybach.github.io/destiny-return-on-investment

I'll be posting it on /r/destinythegame in a few hours' time, so I thought I'd give you a heads up 😄

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/BinarMorker/TimeWastedOnDestiny/pull/35#issuecomment-295792920, or mute the thread https://github.com/notifications/unsubscribe-auth/AFh1qsSgQYtAg5y68Qjya5tqyOTYGes5ks5rx4HsgaJpZM4M6uFB .

remybach commented 7 years ago

Thanks!

Yeah, I'm totally expecting that - in fact, I've worked with the API in the past, so I hope they actually update it!

I can only dream of a lovely REST based JSON API 😍