Fix compatibility with Core_kernel >= 0.15

BinaryAnalysisPlatform / bap

Binary Analysis Platform

MIT License

2.07k stars 273 forks source link

Fix compatibility with Core_kernel >= 0.15 #1460

Closed bcc32 closed 2 years ago

bcc32 commented 2 years ago

Core_kernel 0.15 introduces a Sys module (which is a deprecated value that refers users to core_unix.sys_unix). Also, Result now contains an Error module (which is a monad over the Error case rather than the Ok case).

ivg commented 2 years ago

Thanks, @bcc32! Could you please resolve the conflicts? Otherwise, the changes look good and I will be glad to merge them.

bcc32 commented 2 years ago

Thanks @ivg. I was using this PR as a place to put a patch for nixpkgs, which is currently at v2.4.0, but I should be able to upgrade that once

ivg commented 2 years ago

thanks a lot!