BinaryAnalysisPlatform / bap

Binary Analysis Platform
MIT License
2.07k stars 273 forks source link

Fixes a few bugs in the Thumb semantics #1582

Closed bmourad01 closed 1 year ago

bmourad01 commented 1 year ago

The helper set-nzcv-from-registers calls additional helpers overflow and carry, which compute their results from the addition of two integers. However, the cmp instruction computes the subtraction of two integers, and this wasn't reflected in the usage of this helper function.

Also, the t2ADDrs semantics had a typo in it.