monads: `core_kernel.rope` no longer exists in v0.16

BinaryAnalysisPlatform / bap

Binary Analysis Platform

MIT License

2.07k stars 273 forks source link

monads: `core_kernel.rope` no longer exists in v0.16 #1589

Open bmourad01 opened 1 year ago

bmourad01 commented 1 year ago

It seems this functionality has been separated into the jane_rope package (which currently depends on base v0.16). Would we need to break compatibility with previous versions (i.e. < v0.16.0) of janestreet libraries to upgrade, or hard stop at v0.15? Perhaps a third option exists?

ping @ivg

ivg commented 1 year ago

Do you mean by a hard stop that we shouldn't support versions below v0.15 or above?

bmourad01 commented 1 year ago

By that I mean that one option would be to not support anything above v0.15.

XVilka commented 1 year ago

It's better to support newer Core/Base versions in my opinion, since they will benefit from all the OCaml 5.x multicore and effects work in the future, which would fit BAP quite well for variety of reasons. See also https://github.com/BinaryAnalysisPlatform/bap/issues/1561