Issue with Camlzip 1.12 - Githubissues

BinaryAnalysisPlatform / bap

Binary Analysis Platform

MIT License

2.05k stars 271 forks source link

Issue with Camlzip 1.12 #1607

Closed xavierleroy closed 1 month ago

xavierleroy commented 2 months ago

For reasons explained in https://github.com/ocaml/opam-repository/pull/26207#issuecomment-2216901921 , Camlzip version 1.12 removes the extra field from type Zip.entry. This breaks lib/bap_byteweight/bap_byteweight_signatures.ml: https://github.com/BinaryAnalysisPlatform/bap/blob/95e81738c440fbc928a627e4b5ab3cccfded66e2/lib/bap_byteweight/bap_byteweight_signatures.ml#L103-L114

I suggest not trying to copy the extra data at all.

ivg commented 1 month ago

Thanks @xavierleroy and @bmourad01, closing the issue as fixed in #1609