Closed Rot127 closed 9 months ago
Should be merge to
tracerap-8.1
though, notstable-8.1
I think you can do that. There is an option to change it on GitHub UI.
I think you can do that. There is an option to change it on GitHub UI.
Only have the option to select an already present branch.
Why can't we just have a shell script which does this? Why do we need Python? Other than the fact that it is easy to write, I don't see any other reason. But again it's just a one time effort, so we might as well not force people to run Python when this can be also done with bash.
Guess this is run during build. But nonetheless we should do it in another PR anyways.
I suggest to do at least the basic CI first
@XVilka Just added one. Could it be that you need to approve the run?
I suggest to do at least the basic CI first
@XVilka Just added one. Could it be that you need to approve the run?
Probably Actions need to be enabled first. @ivg could you please do that?
Just figured that we won't catch build errors like the one fixed in https://github.com/BinaryAnalysisPlatform/qemu/pull/32/commits/d1fe736f3acc905b9a09f6bd493245ffa5ca4e3e if there is no code which uses tracewrap. So the CI build is only useful with an arch.
@ivg The tracing for Hexagon is almost done (if I do not find some edge case). But it relies on 8.1. If you find time in the next two weeks, I can open the PR for Hexagon.
@Rot127 sure, shoot it!
Alright. I'll wait for the merge of this so the Hexagon PR doesn't have 5k+ commits. Do you have any comments to this: https://github.com/BinaryAnalysisPlatform/qemu/issues/31?
I enabled the actions and left some comments on the action file. Please, don't hesitate to @-me as otherwise I will most likely miss any updates :)
Sure, I'll address them soon. Thanks
@ivg Please take a look again. Especially at the changes to the workflow.
If you merge it, please don't forget to merge it into tracewrap-8.1
As a final question, do you prefer it to be rebased, squashed, or just merged with a merge commit?
@ivg I think squashed into tracewrap-8.1-base
is fine.
@ivg apparently @Rot127 asked to squash by mistake. We have fixed the history in stable-8.1
and tracewrap-8.1
branches, but now there is protected branch tracewrap-8.1-base
that I cannot remove, could you please remove it?
I can't also remove the protected branch (we should have the same permission btw), so I need to remove the protection before deleting it. I will remove the protection, delete it, and re-instantiate the protection back.
Should be merge to
tracerap-8.1
though.\, notstable-8.1