BinaryMoon / jarvis

A speedy Gutenberg ready theme
https://prothemedesign.com
GNU General Public License v2.0
51 stars 5 forks source link

Page builder Compatibility #36

Closed ronalfy closed 5 years ago

ronalfy commented 5 years ago

Resolves #5

screencapture-localhost-wordpress-2019-07-24-15_40_11

The following changes make the theme page builder friendly.

The header/footer are modular and are included in functions.php.

I've created a sample child theme that adds Beaver Builder compatibility, for example.

https://github.com/ronalfy/jarvis-beaver-builder-child

The attached screenshot shows a custom header/footer for the site using Beaver Builder, but can be extended to other page builders as well.

Will need a fully stretched page template that will accommodate adding content in. Basically, a blank canvas that includes the header and footer and a full-width content area in between.

BinaryMoon commented 5 years ago

Thanks for this Ron! I find the screenshot amazing really cool. I've never used a page builder and didn't realise you could do things quite like this. :)

I've added some comments to your commits.

Thanks!

ronalfy commented 5 years ago

Here's an updated screenshot showing breadcrumbs. I've also attached a video of how a page builder might be used. I've also included a template that is content only so a page builder can take over the content.

screencapture-localhost-wordpress-blog-event-tracking-test-2019-07-25-17_29_06

https://www.dropbox.com/s/1rjimbh4kswmaun/jarvis-page-builder.mp4?dl=0

ronalfy commented 5 years ago

Something that GeneratePress does is it adds a metabox to the side of the post/page that allows you to have a stretched layout and will disable the title. If this is approved, I can work on adding that functionality in.

BinaryMoon commented 5 years ago

All done! :)