BinaryQuantumSoul / sdnext-modernui

SD.Next ModernUI
GNU Affero General Public License v3.0
16 stars 8 forks source link

quick feedback #1

Closed vladmandic closed 5 months ago

vladmandic commented 5 months ago

overal, love it. still quite some things that need fixing...

generating creates a flicker during preview as scrollbars appear/dissapear

after running generate several times, generate button started to dissapear on me - it goes away when i click generate, but doesn't come back when generate is done: image

extra networks clicking on folder does not filter the view

remove buttons with links completely: image

i don't see a point fo home button opening readme: image

settings is broken - there is a main button on the left which just opens near-empty pane image

and then there is button on the right which opens actual settings image

actually - i think this is an overall problem, not settings specific - if a tab has tab control inside it, main tab will be on the main pane, but subtabs appear on the right pane, probably not what we want. perhaps instead of "dynamically" doing that, we can predetermine which sections go to main (left) and which to right.

also probably due to same root cause - not sure what this button is supposed to be, it just opens empty pane image

BinaryQuantumSoul commented 5 months ago

Thanks for the feedback

generating creates a flicker during preview as scrollbars appear/dissapear

after running generate several times, generate button started to dissapear on me - it goes away when i click generate, but doesn't come back when generate is done: image

Yes this one is on the trello, I haven't searched the cause yet, but it's probably a quick fix.

extra networks clicking on folder does not filter the view

Didn't know, added it to the trello

remove buttons with links completely: image

Ok didn't know which one to leave. Do I keep the reload UI one ?

i don't see a point fo home button opening readme: image

Sure, but what should I put there then ? Initially it was information about Anapnoe's repo and sponsorship.

settings is broken - there is a main button on the left which just opens near-empty pane image

and then there is button on the right which opens actual settings image

Yes, I thought the right settings tab is useful so I left it there but we should hide the subtab in system tab then ? Or remove the quick gear icon ?

actually - i think this is an overall problem, not settings specific - if a tab has tab control inside it, main tab will be on the main pane, but subtabs appear on the right pane, probably not what we want. perhaps instead of "dynamically" doing that, we can predetermine which sections go to main (left) and which to right.

also probably due to same root cause - not sure what this button is supposed to be, it just opens empty pane image

I don't see what you mean here, do you have other examples? Actually it's already predetermined, it's all templates that either teleport a whole tab or divs using their elem ids. The settings on the right teleports the subtab from system tab, that's why it's empty there. The empty tab is the control tab, I added it but it's empty since I haven't done the template yet (a1111 doesn't have control tab).

vladmandic commented 5 months ago

Ok didn't know which one to leave. Do I keep the reload UI one ?

browsers have reload button already, no need.

Sure, but what should I put there then ? Initially it was information about Anapnoe's repo and sponsorship.

probably nothing, just a non-clickable icon

Actually it's already predetermined, it's all templates that either teleport a whole tab or divs using their elem ids.

ok, so we should probably have better predefined list of whats teleported. i like idea that settings are on the right, but right now its broken up to be settings headings in left and actual settings in the right.

BinaryQuantumSoul commented 5 months ago

browsers have reload button already, no need.

probably nothing, just a non-clickable icon

Ok x2

ok, so we should probably have better predefined list of whats teleported. i like idea that settings are on the right, but right now its broken up to be settings headings in left and actual settings in the right.

I mean the right nav bar kinda is the list of what's teleported and the elements you see in the templates are the ones which are teleported, but I guess we could make a list. By the way, in the trello I have made a list of lacking elem_ids. Right now there is only one, but I may find other ones when doing the templates.

I'll hide the settings subtab and select the second one. Such that when using the theme the settings are in the gear right tab

BinaryQuantumSoul commented 5 months ago

I implemented all the opinionated UI fixes in latest. Still need to fix the two bugs but will track progress on trello