search

BinaryQuantumSoul / sdnext-modernui

SD.Next ModernUI
GNU Affero General Public License v3.0
15 stars 7 forks source link

[Issue] In mobile mode, Control checkbox "Input image" gets auto-checked in landscape orientation #62

Closed lbeltrame closed 2 weeks ago

lbeltrame commented 1 month ago

Issue Description

When trying to use Control from Firefox Mobile, I noticed that the "Input image" checkbox gets checked when moving to portrait to landscape mode. In other words:

  1. Rotate phone to be in landscape orientation
  2. Check "Control" and Uncheck "Input image" if it's checked
  3. Rotate the phone in portrait orientation
  4. Move back the phone in landscape orientation

The Input image checkbox should be checked after these steps, even if it were unchecked before. This happens every time the orientation changes.

Backend

Firefox

Branch

Mobile

Version Platform Description

Pixel 8, Firefox Mobile.

Relevant log output

No response

Acknowledgements

BinaryQuantumSoul commented 1 month ago

This is because you don't have the checkboxes on mobile, instead they are automatically checked when moving to fill the three tabs. https://github.com/BinaryQuantumSoul/sdnext-modernui/blob/bd7937d845bec45e69f97e486905c2d2d72f781f/javascript/sdnext-modernui.js#L118-L119 image

When you come back to landscape and exit mobile mode, they were indeed checked.

Still can be fixed though, I was just explaining the reason

BinaryQuantumSoul commented 2 weeks ago

Fixed