BinaryQuantumSoul / sdnext-modernui

SD.Next ModernUI
GNU Affero General Public License v3.0
15 stars 7 forks source link

[Issue] Generate button's progress is wrong #76

Closed AznamirWoW closed 1 week ago

AznamirWoW commented 1 week ago

Issue Description

'Generate' button progress seems to go 2x the actual rate, shows 100% while the generation is only at 25/50 steps for a single image. For batches and X/Y/Z scripts the completion shows 100% after just the first image generated and stays like that until the whole process finishes.

Backend

Firefox

Branch

Desktop

Version Platform Description

Version: app=sd.next updated=2024-06-28 hash=6fb7cee8 branch=dev

Relevant log output

No response

Acknowledgements

vladmandic commented 1 week ago

which workflow? standard txt2img? any thing added to workflow (such as face-hires, adetailer, etc.)? which ui? standard or modernui?

i cannot reproduce using standard txt2img and standard ui.

AznamirWoW commented 1 week ago

which workflow? standard txt2img? any thing added to workflow (such as face-hires, adetailer, etc.)? which ui? standard or modernui?

i cannot reproduce using standard txt2img and standard ui.

Modern UI, text to image. Started around master to dev merge a few days ago.

image

AznamirWoW commented 1 week ago

Also happens with standard UI image

AznamirWoW commented 1 week ago

@vladmandic looks like it happens with 'DPM SDE' sampler, but not with 'Euler a' or some others for a single image

but a batch and x/y/z grid get '100% finishing' after 1st image regardless

vladmandic commented 1 week ago

right - that helps a lot! issue is that some samplers have internal number of steps higher if they are samplers of higher order - such as DPM SDE. i've included that in step calculation - fixed in dev branch.

xyz grid issue is separate.

AznamirWoW commented 1 week ago

@vladmandic after this fix img2img progress % is going half the actual rate, both DPM SDE and Euler a samplers.

vladmandic commented 1 week ago

fixed (again), hope its ok this time.