BinaryStudioAcademy / bsa-2024-gitfit

Application for collecting and analyzing developers activity on git based projects.
0 stars 0 forks source link

feat: Sign Up page fields validation, Sign up button inconsistent text #131

Closed VeronikaHordus closed 6 days ago

VeronikaHordus commented 2 weeks ago

What feature?

  1. Sign Up button text inconsistent to the Mockup. The text of the button should be Create Account.

  2. Field validation rules : Email field:

Name field:

Password must include:

Screenshots

image

kolibri753 commented 2 weeks ago

Clarification (about Email):

  1. Domain Part: Should the dot (.) in the domain part be followed by at least two letters? For example, is username@example.c valid, or should it be rejected?
  2. Local Part: Is a dot followed by a hyphen (.-) allowed in the local part? For instance, would user.-name@example.com be valid? And what about user.name-@example.com?

P.S. I believe both cases are invalid but wanted to confirm.

VeronikaHordus commented 2 weeks ago

I believe its good to make both ways invalid (sorry for long responce). I will add your clarifications in main info for validation, thanks!

AnnaRomaniuta commented 6 days ago

@kolibri753 Hello, I'm a little confused, maybe you can help me. When I try to register with an invalid address, for example without a domain part or without a special character @, I receive a message from the browser, not from the applicationImage

AnnaRomaniuta commented 6 days ago

In general, everything works and looks good, a bug has been created for some discrepancies. Good job!