BinaryStudioAcademy / bsa-2024-gitfit

Application for collecting and analyzing developers activity on git based projects.
0 stars 0 forks source link

feat: Adjust root permissions #350

Open liza-veis opened 3 days ago

liza-veis commented 3 days ago

What feature?

Adjust needed permissions and make sure all of them work as expected. The resources should be disabled on the backend as well.

Rules:

Screenshots

No response

VeronikaHordus commented 2 days ago

For QA: Check whether the link on the Logo on header redirects users to correct pages with certain permission type.

GvoFor commented 2 days ago

Questions

liza-veis commented 2 days ago

If rule states "...: View All Projects, Manage All Projects.", then this means that user shoud have AT LEAST one of the listed permissions, right? (or all of them?)

yes, one of them.

If there is nothing left to display in the menu (for example user has only View All Projects permission and not Manage All Projects, then both edit and delete options should disapear), then I should not render the menu component (button with ellipsis) itself at all, right?

yes, would be nice to hide the options menu.

In rules list, Manage Access permission was mentioned, but currently in project we have Manage User Access. Are these the same permissions? or should I create new Manage Access permission? or should I rename Manage User Access to Manage Access?

yep, It's the sam permission, no need to rename or create a new one.

Our project details page contains contributors list and it can be accessed with just View All Projects permission, but Contributors page can be accessed only with Manage All Projects permission. So should I render contributors list in this case?

Contributors page will be for all contributors configuration, so only users with Manage All Projects (who is able to edit contributors) can access it. It will be hard to show all contributors, but disable actions for some of them if user has/doesn't have project-specific permissions. But it's ok for the project details page, + contributors on this page are mostly for view and tracking purposes, so users with View All Projects permission should see them.

VeronikaHordus commented 1 day ago

@GvoFor Everything seem to work as required, only I have one point to make clear. The Project Access Managment page is unaccessible for user with Manage Access rights untill he has also the View All Projects permission. (If I wold paste the URL of the Project Access Managment page I am redirected to the 404 page). Is that right?

GvoFor commented 1 day ago

Hi. Thanks for noticeing. Looks like a bug for me. I think I should fix it However I'm not sure