search

Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Comments are not easy to read for the low contrast to the background #121

Closed Naruto-Sasuke closed 7 years ago

Naruto-Sasuke commented 7 years ago

I think it is better to darken the comments a little bit.

Binaryify commented 7 years ago

Could you provide some screenshot?

Naruto-Sasuke commented 7 years ago

_102 I think it is a little hard to read the comments

jens1o commented 7 years ago

@Binaryify What do you expect, should we make the comments a little bit brighter?

I'm busy, but I try to figure out the best-fit color as soon as possible.

Binaryify commented 7 years ago

@jens1o Actually I don't think make the comments be brighter is a good idea How about you

vvs commented 7 years ago

@Binaryify, @jens1o I actually agree that the current comment color is way too close to the background, and it doesn't match the color in the original Atom's theme.

There, the color is: #818998. In OneDark pro the color is ; #5c6370

If you wish, I could create a PR that fixes this and brings the comments in sync with the original theme, and it will make them much easier to read.

Binaryify commented 7 years ago

@vvs Yes, you can

vvs commented 7 years ago

Ah, sorry for the confusion. The brighter color in Atom (#818998) was my own setting overriding the original #5c6370.

So, I am not sure what to do. OneDark Pro is already currently fully in sync with Atom theme w.r.t. comments. I'd assume it would be good to be in sync with the original theme, and not divert from it too much. So the issue of hard to read comments should be reported to the original theme author (upstream).

Personally, I just keep the local (forked) tweaks that suite my tastes even though they divert a bit from the upstream Atom theme.

In case you want to see the brighter comments, here's my changes for that: vvs/OneDark-Pro@a983b4abf42879415cd10d64237f827dcb38f31e

jens1o commented 7 years ago

I also don't know what to do, sorry.