Theme more vibrants than on Atom

Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme

MIT License

1.52k stars 289 forks source link

Theme more vibrants than on Atom #125

Closed ghost closed 6 years ago

ghost commented 7 years ago

Hi,

This theme is more vibrant than the Atom theme. Is VSCode not using the same display color profile as Atom? Atom is softer (which I prefer and matches the screenshots).

TIA!

VSCode left, Atom right

Binaryify commented 7 years ago

Will improve this when I merge this PR https://github.com/Binaryify/OneDark-Pro/pull/123

lprhodes commented 7 years ago

I don't believe so, that pull request looks to make VSCode even more vivid.

At the moment the colors used are correct but VSCode is still more vibrant.

It could be related to this https://github.com/Microsoft/vscode/issues/24569

lprhodes commented 7 years ago

I misread sorry, hopefully you can solve the issue but it looks like VSCode's version of electron is older than Atom's which may be cause issues on the P3 capable displays

Binaryify commented 7 years ago

Maybe, I'll pay attention to it

vvs commented 7 years ago

Hi folks, I tried the latest color changes from the master, namely #123 and I must say, it is now painful for me to look at my code. WAAY too vivid.

Even before the change the colors in VS Code were a bit more vivid as compared to Atom, but with these even more vivid colors from #123 is is painfully obvious the difference.

If possible, could you please make those more vivid colors as a separate theme, not the main/default one.

Thank you!

vvs commented 7 years ago

Here's what I see on my PC.

First, for the reference, the Atom 1.19 beta5: atom-1 19 betea5

Then VS Code with Dark One theme v. 2.9.8: vs_code_2 9 8

And this is from the latest master, with even more vibrant/vivid colors: vs_code_master_vivid

Pay attention to the red color for variables. It is certainly over-vibrant esp. when compared to the original Atom colors.

Please consider moving these extra-vibrant colors to separate theme and not release them as a main theme. Thank you!

jens1o commented 7 years ago

That's a good idea @vvs ! I thought @Binaryify implemented it like you said, in an external theme, as long as we're still exploring it...

vvs commented 7 years ago

@jens1o I checked the latest freshly released version and it is so, there are two themes, the main one and another one.

But for some reason, the vivid theme is called One Dark Pro xxx and not really enabled, since it references the wrong file name.

jens1o commented 7 years ago

Thank you, we'll fix that with the next recovery release... @Binaryify Do you do that or should I fix that problem?

Binaryify commented 7 years ago

Oh, my mistake, will fix that tomorrow

Binaryify commented 7 years ago

@jens1o Done

vvs commented 7 years ago

@Binaryify I'd also change the name of the vivid theme. Currently, it is rather cryptic One Dark Pro xxx

Something like One Dark Pro Vivid would be much better, I think.

Binaryify commented 7 years ago

@vvs I just publish a new version, sorry

jens1o commented 7 years ago

I think we can get rid of this issue, since Visual Studio Code allows doing this since July release: https://code.visualstudio.com/updates/v1_15#_workbench

Thoughts? @Binaryify

We would do italic in standard, and allow resetting this via a snippet in the user settings.

Binaryify commented 7 years ago

@jens1o Yup, What do you think we should do, update the docs?

jens1o commented 7 years ago

Yeah, I think we should do that. Do you take that job?

Binaryify commented 7 years ago

@jens1o yes

Binaryify commented 7 years ago

@jens1o maybe will update at this weekend