search

Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Bring JavaScript constants color in sync with Atom #126

Closed vvs closed 7 years ago

vvs commented 7 years ago

Currently, in 2.9.8, JavaScript's constants color is: #e5c07b

In the latest Atom 1.19-beta5, the color for JS constants in Dark One theme is: #d19a66, which is much more pleasant to my eyes (and less vivid and not so out-of-place for this dark theme).

Binaryify commented 7 years ago

You can look this https://github.com/Binaryify/OneDark-Pro/pull/123

vvs commented 7 years ago

@Binaryify thanks for the quick response!

But #123 does not in fact change these colors (for JS constants). Not to mention that the whole change in #123 is way, way too vivid for me to be usable :(

Binaryify commented 7 years ago

Oh, I misunderstand that, will improve that, thx~

Binaryify commented 7 years ago

I improve it, please update and check it, thx~

vvs commented 7 years ago

@Binaryify, almost there, thank you!

I've created a PR to fix the remaining part (JS math colors): #130

Binaryify commented 7 years ago

@vvs I see it

vvs commented 7 years ago

And this issue can be considered fixed now. Thanks!