Comment is too dark

[Yensan]

When I turn on OneDark-Pro, comment text is too dark to see. Please give a brighter color and make an enough color contrast between the background color and comment text color. vs code default theme "Default Dark+" is better in color contrast of comment/background. Maybe you can just folow the setting of comment text color.

[garritfra]

Fix Request :)

[jens1o]

<< is an idiot.

[jens1o]

tbh, I think the change is too extrem: Having now:

Incoming:

[garritfra]

maybe make it a little bit darker again?

[jens1o]

cc @Binaryify for his opinion.

[Binaryify]

@garritfra I think that is good, could you send the PR?

[garritfra]

Done. Relatively new to GH so I don't know if I have done everything correctly.

[Yensan]

Great job ! Thanks all of you.

cc @Binaryify for his opinion.

Maybe he is right, because colors in this theme is designed for token or var in code, but grey is for comment / block comment.

[Yensan]

<<is an idiot.

May you guys think this issue is not necessary. But for a user, although I can edit the color hex code, but I don't want to edit it every time when it updating. Life is short, we need out-of-the-box theme&thing.

[jens1o]

@Yensan Please keep calm. It's not the time to come up with such phrases. Of course we're on it. Remember, that we're doing this in our freetime(and for free). In 20 minutes for example, I need to go to school. You may take a look at custom modifications, that can be located into your user settings.

[Yensan]

Thanks you guys for the theme, and thank you for advice.

[Binaryify]

@Yensan thank you too 🎉

[garritfra]

should this issue be closed?

[Binaryify]

@garritfra I think yes

[jens1o]

@Binaryify

I think you forgot to update the end and the beginning of a comment. Do you take that job?

[Binaryify]

@jens1o oh, I ignore it, wait

[Binaryify]

@jens1o done