Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

[FIXED] v2.10.15 comments changed #150

Closed maxmilton closed 7 years ago

maxmilton commented 7 years ago

Commit https://github.com/Binaryify/OneDark-Pro/commit/9bc463439e8b28a63220d1a5da433a94cdd7341e drastically changed how comments are styled.

This is just a quick tip for anyone who wants to revert to the old comment style. Add this to your user settings:

    "editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "scope": "comment, punctuation.definition.comment",
                "settings": {
                    "foreground": "#5C6370"
                }
            },
            {
                "scope": "comment.line.double-slash,comment.block.documentation",
                "settings": {
                    "fontStyle": "italic"
                }
            }
        ]
    },

Thanks for the great theme, it was a big factor that allowed me to switching to VS Code from Atom :heart:

Binaryify commented 7 years ago

thank you❤️

jens1o commented 7 years ago

@Binaryify Personally, I would add this to the readme, and close this issue. Users will more likely read the readme than searching in the issues.

Binaryify commented 7 years ago

@jens1o you are right, will add it to the README

Binaryify commented 7 years ago

@jens1o done

jens1o commented 7 years ago

thx

xthezealot commented 7 years ago

Thanks @MaxMilton for the snippet and @Binaryify for the theme.

However, I still don't understand how 9bc4634 could be an improvement. On the Vivid version, the comments now have the same color as any other uncolored fragment so identifying them at first sight takes more time:

capture d ecran 2017-10-12 a 11 25 54

jens1o commented 7 years ago

@arthurwhite The vivid version is a relict of the past. You may want to end up on using the normal version and modifying your user settings to disable the italic.

xthezealot commented 7 years ago

That's too bad, I really liked this energetic vibe from the Vivid. But OK, thank you for the clarification.