search

Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Typo in OneDark-Pro-vivid.json comment color code #151

Closed dcervenkov closed 7 years ago

dcervenkov commented 7 years ago

https://github.com/Binaryify/OneDark-Pro/blob/9bc463439e8b28a63220d1a5da433a94cdd7341e/themes/OneDark-Pro-vivid.json#L87

I'm pretty sure this is a typo as hex color codes have 6 digits. You probably wanted to write #5c6370. Without this correction, the comments are the same color as normal text.

jens1o commented 7 years ago

@dcervenkov That's a good first pr. Do you want to take it? :)

dcervenkov commented 7 years ago

@jens1o A one character pull request? :smile: Sure, I'm on it.

jens1o commented 7 years ago

well, apparently @Binaryify was faster ;)

dcervenkov commented 7 years ago

@jens1o Faster than what?

jens1o commented 7 years ago

faster than you :(