Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Single line comments and JSDoc comments not italic #153

Closed floriangosse closed 6 years ago

floriangosse commented 7 years ago

In my javascript code the single line and JSDoc comments have a strange behavior: The characters which indicates that the following is a comment are italic but the comment itself is not italic anymore.

image

To make sure that no other extension cause this error I disabled all extensions except the theme itself and tried it again but I didn't change anything.

jens1o commented 7 years ago

@Binaryify

But I think this behaviour is on purpose, and I love it, although I dont use //// comments

floriangosse commented 7 years ago

I used //// to show the difference.

I saw italic comments it on different screenshots of the theme so I thought this seems to be a bug. If it's not a bug please close this issue and I will try to find a solution. :-)

Binaryify commented 7 years ago

@jens1o @floriangosse they have same scope, if I fix it, all comment text will italic image image

ekfuhrmann commented 6 years ago

It seems odd that comments in JS are not italic, yet everywhere else (html, pug, php, scss, css) they are italic.

Would you be willing to at least standardize them so that JS commenting works the same as the others, whether that be italic or not?

Binaryify commented 6 years ago

@ekfuhrmann no, some people like this, if another people don't like this, they also can config that on setting.json

ekfuhrmann commented 6 years ago

How would one go about editing this within setting.json? I'm unfamiliar with the terms to make the change and don't see anything in the documentation regarding italics.

Binaryify commented 6 years ago

@ekfuhrmann you can read this part https://binaryify.github.io/OneDark-Pro/#/?id=workbench-theming

floriangosse commented 6 years ago

@Binaryify you can only change colors but not the style of the token.

floriangosse commented 6 years ago

I found out that you can set more then just colors.

// ...
"editor.tokenColorCustomizations": {
    "textMateRules": [
        {
            "scope": "comment.line.double-slash,comment.block.documentation",
            "settings": {
                "fontStyle": "italic"
            }
        }
    ]
},
// ...