Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

about the markdown #159

Closed blackier closed 5 years ago

blackier commented 6 years ago

can you support more syntax for the markdown? I use the vscode to write markdown,but the onedark-pro don't have a good support for mardown.So I think you can support more syntax for the markdown. Or you have a test that use the vscode to write markdown,then you may want to do it.

Binaryify commented 6 years ago

have any good idea?

Binaryify commented 6 years ago

could you provide some screenshot?

svipas commented 6 years ago

@blackier Can you reproduce this again? Also, could you send us the markdown itself to see what colors are missing?

blackier commented 6 years ago

@Binaryify @svipben I am sorry,as a newcomer, I don't visit GitHub so often that I didn't see your news in time.The picture is as follows: eg01 eg02 eg03 My idea is that the code snippet can be as highlighted as the type of the identifier

`int main(){return 0;}`

It's great like this! And the latest updates, Obviously, the support for md is better and I like it very much,thank you!

svipas commented 6 years ago

@blackier Can you send us the code instead of pictures? I will test it outside MD and inside MD.

blackier commented 6 years ago

@svipben Yes. c

struct proc_struct {
    enum proc_state state;                      // Process state
    int pid;                                    // Process ID
    int runs;                                   // the running times of Proces
    uintptr_t kstack;                           // Process kernel stack
    volatile bool need_resched;                 // bool value: need to be rescheduled to release CPU?
    struct proc_struct *parent;                 // the parent process
    struct mm_struct *mm;                       // Process's memory management field
    struct context context;                     // Switch here to run process
    struct trapframe *tf;                       // Trap frame for current interrupt
    uintptr_t cr3;                              // CR3 register: the base addr of Page Directroy Table(PDT)
    uint32_t flags;                             // Process flag
    char name[PROC_NAME_LEN + 1];               // Process name
    list_entry_t list_link;                     // Process link list
    list_entry_t hash_link;                     // Process hash list
};

c

int
do_fork(uint32_t clone_flags, uintptr_t stack, struct trapframe *tf) {
    int ret = -E_NO_FREE_PROC;
    struct proc_struct *proc;
    if (nr_process >= MAX_PROCESS) {
        goto fork_out;
    }
    ret = -E_NO_MEM;

}

This is good. asm

    movl %esp, 4(%eax)
    movl %ebx, 8(%eax)
    movl %ecx, 12(%eax)
    movl %edx, 16(%eax)
    movl %esi, 20(%eax)
    movl %edi, 24(%eax)
    movl %ebp, 28(%eax)
svipas commented 6 years ago

@blackier This is the problem with VS Code itself.

Test it with Dark+ default theme and you will see. But we definitely need to fix it somehow by making it better because currently, it's very bad...

I guess it makes sense to open issue in VS Code to fix their scopes of Markdown files.

blackier commented 6 years ago

@svipben Got it, look forward to the update.

jens1o commented 6 years ago

Please understand that we do not allow ads for other products.

svipas commented 6 years ago

@jens1o I'm always open to cooperate and merge our products into one.

jens1o commented 6 years ago

@svipben Then feel free to maintain your fork and open pull requests at our end. It's you who started their own theme, so we do not need to give up our passion.