Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Searched word and highlighted word are the same #166

Closed Ivkaa closed 5 years ago

Ivkaa commented 6 years ago

When I want to rewrite something I searched for, when I select the area, the color of background highlight from searching is same as my highlighted part, which is very confusing, because I don't know what I highlighted. In this example I highlighted the argument in function. image

darsain commented 6 years ago

Also bugged me a lot (among other similar colors issues this theme has) so I did a bit of digging, and it seems to be a deeper issue upstream: https://github.com/Microsoft/vscode/issues/34105

But as suggested, even before it's solved it's still possible to add visual cues by using colors with transparency, since these selection/findMatch backgrounds are overlayed on top of each other.

Binaryify commented 6 years ago

I had improve it in the new version, please update and check it if it's better

darsain commented 6 years ago

Selection highlight is still indistinguishable from search highlight for me.

Binaryify commented 6 years ago

have not idea, do you have any advice @darsain

darsain commented 6 years ago

As explained in https://github.com/Microsoft/vscode/issues/34105, the problem here is that search highlight background is above selection highlight background, or maybe the other way around and they are the same colors, one of the two. Solution until this gets some better handling in vscode is using colors with alpha channel. That way even if 2 backgrounds are on top of each other they are still distinctive since the colors will "amplify" one another.

I don't have a specific color scheme to use here though. There is a lot of highlight variables in theming vscode. It'd require some playing around and tweaking.

Binaryify commented 6 years ago

@darsain if you have some good color scheme, could you let me know, and I will improve it

LukasPolak commented 6 years ago

hi, @Binaryify it is possible to make an options for example:

to see the difference for highlighting? thanks

ghost commented 6 years ago

@Ivkaa @darsain @LukasPolak @Binaryify created this issue: https://github.com/Binaryify/OneDark-Pro/issues/194 which will improve word highlighting after 1.21 version will be released. Stay tuned :)

svipas commented 6 years ago

Bad news, seems there's no such thing like editor.selectionBorder which is for selected text with mouse.

Good news I created issue in VS Code: https://github.com/Microsoft/vscode/issues/45292

svipas commented 6 years ago

Trying to push VS Code team to fix some border issues, even suggested making a PR. This issue will be definitely fixed. Stay tuned :)