Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

cursor's color is better for blue like atom #168

Closed iiinsomnia closed 6 years ago

jens1o commented 6 years ago

So you'd like to have the cursor color in blue and not in yellow?

Feel free to do this in your settings: https://binaryify.github.io/OneDark-Pro

Leaving the issue open for @Binaryify 's response

Binaryify commented 6 years ago

will consider it

Binaryify commented 6 years ago

@IIInsomnia done

lixiaoyan commented 6 years ago

image

OneDark Pro + VSCodeVim

Binaryify commented 6 years ago

@lixiaoyan any more detail?

lixiaoyan commented 6 years ago

@Binaryify Vim normal mode uses block cursor, which will highlights the whole char next to the cursor. The character highlighted should use white as its text color rather than its original text color.

Binaryify commented 6 years ago

@IIInsomnia @lixiaoyan maybe need some time to improve it

Binaryify commented 6 years ago

image image how about this

lixiaoyan commented 6 years ago

@Binaryify Looks good, wondering if it will be released soon.

Binaryify commented 6 years ago

@lixiaoyan it just released, you can check it now

iiinsomnia commented 6 years ago

thanks!

lixiaoyan commented 6 years ago

image image

Select text in vim mode (visual mode)