Discuss: JSX's component tags color should be red or yellow

[Binaryify]

I notice that some people think it should be red and others think it should be yellow, but I don't know which one will be better(now is red) https://github.com/Binaryify/OneDark-Pro/issues/181 https://github.com/Binaryify/OneDark-Pro/issues/182 https://github.com/Binaryify/OneDark-Pro/issues/183 I have not idea now @PhilMcVay @zalishchuk @IAmStrong @bendersej

[jens1o]

Personally I'd stick to yellow, because a little bit more contrast is always good.

[PhilMcVay]

I like the red highlighting as it separates the class/component declaration and the JSX/HTML tags. All other HTML elements highlight red as well so I find it reads easier if the JSX tags are the same colour.

I don't mind either way to be honest. If the majority vote yellow it's understandable.

[keeganstothert]

yellow please!!! the red is not distinct and differs from the language-babel highlighting in atom

[zalishchuk]

As I mentioned in my issue, my personal opinion is One Dark Pro should match Atom One Dark syntax used with Atom language-babel grammar.

[IAmStrong]

Yellow please, as it clearly separates tags from components.

[svipas]

I suggest using Yellow. Because right now there's everywhere red color. And as @jens1o said a little more contrast is always good.

[Binaryify]

@PhilMcVay I think I should change it back, but I will tell you how to change it to yellow in your setting.json

[PhilMcVay]

That's fine @Binaryify. Thanks.

[zalishchuk]

@Binaryify so what's about proposal, should not we follow language-babel grammar?

[Binaryify]

@zalishchuk I will make it look like as atom's language-babel grammar's highlight

[Binaryify]

@PhilMcVay add this in your setting, it will make it red

"editor.tokenColorCustomizations": {
    "textMateRules": [
      {
        "name": "js/ts support.class.component",
        "scope": "support.class.component",
        "settings": {
          "foreground": "#e06c75ff"
        }
      }
    ]
  },