search

Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Different colors in String Interpolation for a nicer visual grepping #191

Closed Or3stis closed 6 years ago

Or3stis commented 6 years ago

The current string interpolation configuration is something like this screen shot 2018-02-25 at 17 52 12 (OneDark Pro) In the first line, it is quite easy to distinguish between the string and the variable. On the other hand, the majority of the second line is colored red, making the visual distinction more difficult.

One Dark in Atom handles string interpolation like this screen shot 2018-02-25 at 17 53 22 (One Dark in Atom) And the Dark+ in vscode has a different approach screen shot 2018-02-25 at 17 52 34 (Dark+ in vscode)

These color themes provide a nice visual grepping for interpolated strings.

In my editor, I have made this adjustment to the OneDark Pro

screen shot 2018-02-25 at 18 18 11

This color change is closer the Dark+ than One Dark though.

Is this something that you would like me to contribute?

jens1o commented 6 years ago

I like it, but let's wait what @Binaryify says.

Binaryify commented 6 years ago

good, I will improve it

Binaryify commented 6 years ago

I think you can send a PR about this