Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

New colors after 1.21 version of VS Code #194

Closed ghost closed 6 years ago

ghost commented 6 years ago

Hi, VS Code 1.21 is still not released, but I created this issue as a reminder for myself to create a PR after VS Code will be released.

editorActiveLineNumber.foreground - https://github.com/Microsoft/vscode-docs/blob/vnext/release-notes/v1_21.md#coloring-of-active-line-number

notifications / border color of editor highlights / terminal - https://github.com/Microsoft/vscode-docs/blob/vnext/release-notes/v1_21.md#new-theme-colors-and-removal-of-old-colors

jens1o commented 6 years ago

@bsvipas Fyi you can work with the Insiders version, too. :)

LordZane commented 6 years ago

1.21 now released!

svipas commented 6 years ago

@LordZane yes you're right. I will create a PR today. 🎉

EDIT 1: Selection and active line number colors/borders are done. Left Notifications, but need to create an extension which triggers them to test colors.

EDIT 2: Created Notification Tester extension for VS Code to test Notification Center and started to work on notifications coloring. https://marketplace.visualstudio.com/items?itemName=svipben.notification-tester

svipas commented 6 years ago

@Binaryify Already created PR: https://github.com/Binaryify/OneDark-Pro/pull/201

Binaryify commented 6 years ago

good job @svipben