search

Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

integrated terminal colors problem after 2.12.7 #195

Closed LukasPolak closed 6 years ago

LukasPolak commented 6 years ago

After update to version 2.12.7 I have a problem with integrated terminal colors

integrated terminal colors problem

imfing commented 6 years ago

@LukasPolak
Same problem. I checked, this only occurs in powershell that the color resembles the background.

Hope the author solve this. It's too hard to distinguish what I have input. image (There is a -v 😂

Binaryify commented 6 years ago

I just publish a new version, please update and check if it have been fix

Binaryify commented 6 years ago

@LukasPolak @mtobeiyf

imfing commented 6 years ago

@Binaryify Much better. Thanks for the quick fix. image

PixelT commented 6 years ago

For me it's still broken, I had white font color, now I have as -v on image above...

Binaryify commented 6 years ago

@PixelT could you provide some screenshot?

PixelT commented 6 years ago

@Binaryify

Earlier I had white text color on this blue & green elements

Binaryify commented 6 years ago

@PixelT so you want it be pure white right?

LukasPolak commented 6 years ago

for me is fixed now! thanks for the quick fix! appreciate it

Or3stis commented 6 years ago

This issue may depend on the local configuration of your terminal colors. If your default terminal colors are light theme based (white background), then some colors will not be displayed currently using this theme (dark background) in vscode.

@PixelT, @LukasPolak can you share your terminal color configuration of your .bash_profile so we can test this?

It seems odd that the terminal.ansiBrightBlack needs to use a light color value to be legible in your settings.

Binaryify commented 6 years ago

@Or3stis maybe it should be more light

svipas commented 6 years ago

I suggest returning back as it was. Just delete the terminal coloring and keep to default as it was before.

Or3stis commented 6 years ago

@svipben why?

With the updated colors, the terminal looks more consistent with the rest of the color theme.

I would prefer to investigate the issue. If it affects only all PowerShell users or a portion of PowerShell there might be an issue with their configuration. I have been using that color scheme for a couple of weeks before I made the PR without any issue.

As I said, it seems odd that the terminal.ansiBrightBlack color needs a white color value to display text.

svipas commented 6 years ago

image

I never had such issues with default terminal coloring which looked perfect.

For me the "terminal.ansiWhite" is bad.

Or3stis commented 6 years ago

I see what you mean.

It is best to revert the changes then.

I will keep the updated colors in my settings to test them further.

svipas commented 6 years ago

@Or3stis I will create PR which removes terminal coloring and keeps it as it was by default. Anyways thanks for contributing for this theme, try to test all possible cases and when you think it will be ready you can create new PR which can be reviewed. But my suggestion is to keep it always as default to reduce problems like this and keep original coloring since it's terminal, not the editor itself.

svipas commented 6 years ago

Done in this PR: https://github.com/Binaryify/OneDark-Pro/pull/205

adrigm commented 6 years ago

I used this theme because this was the only One Dark theme for VS Code that changed the integrate terminal colors.

svipas commented 6 years ago

@adrigm If you're only one who chooses this theme because of integrated terminal coloring you can easily edit your User Settings to include your own coloring for the integrated terminal. But if there are more people like you we should consider about new theme especially with terminal coloring like it's with Vivid.

But it's very hard to color the terminal since everyone uses different coloring and it can introduce a lot of problems and confusions. My suggestion is to not colorize integrated terminal to get the same color in the real terminal and vice versa.

https://code.visualstudio.com/docs/getstarted/theme-color-reference

svipas commented 6 years ago

Okay I tested and without terminal coloring, there are some problems, for e.g. with yellow in the integrated terminal because of our foreground which is not white. So I included the fix in this PR https://github.com/Binaryify/OneDark-Pro/pull/206. I reverted back @Binaryify terminal colors like it was before. I also improved a little bit green color to not be so bright.

This will be our first steps to perfect integrated terminal coloring.

@adrigm You can use again this theme 😄

svipas commented 6 years ago

@adrigm PR was merged so you will have terminal coloring again, of course not the full, but the critical parts which were not consistent with the theme itself will be fixed.

Thanks, @Binaryify for merging it!

I guess @LukasPolak this issue can be closed?

LukasPolak commented 6 years ago

@Binaryify @svipben I think that issue can be closed