Some terminal colors are identical

Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme

MIT License

1.52k stars 289 forks source link

Some terminal colors are identical #280

Open RomanKornev opened 5 years ago

RomanKornev commented 5 years ago

https://github.com/Binaryify/OneDark-Pro/blob/fd373cb10c11ec9bb2373360fec49dec51397c8e/src/editor.json#L75-L91

Terminal Green, Yellow, Cyan, White colors are identical to their bright variant. Caused by: 38a6a99 @LukasPolak. In v2.17.7 they used default values, now they are indistinguishable from each other.

LukasPolak commented 5 years ago

@RomanKornev I will fix that problem ASAP.

LukasPolak commented 5 years ago

@Binaryify @jens1o is a bright color variant for terminal colors the desired state?

Binaryify commented 5 years ago

have no idea about that

jens1o commented 5 years ago

@LukasPolak Could you elaborate on what means bright for you? Bright or brighter?

LukasPolak commented 5 years ago

@jens1o bright means for me bright variant of the original color, but brighter is also the option 🤷‍♂️

eddylin commented 4 years ago

a little hard to read in wsl.

eddylin commented 4 years ago

Directory names