Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Color change for constant.character.format.placeholder.other.python #317

Closed holdenkilbride closed 5 years ago

holdenkilbride commented 5 years ago

https://github.com/Binaryify/OneDark-Pro/blob/1138b93ea8bf5b646f9f95b3247d8912c7550b83/src/syntax.js#L575

The current color of green is the same as the color for the string syntax. This should be changed to 'whiskey' to allow syntax highlighting relating to Python string formatters to stand out.

{
  name: 'constant.character.format.placeholder.other.python',
  scope: 'constant.character.format.placeholder.other.python',
  settings: {
    foreground: colorObj['whiskey']
}
Binaryify commented 5 years ago

could you provide the code what it can effect

holdenkilbride commented 5 years ago

I'm not sure I follow? An example of what I am referring to is the following:

def hello(something):
    print('hello{something}'.format(something=something))

The text in between the curly braces '{something}' would be colored whiskey. Almost all other VSCode themes follow this highlighting model.

Did you want a merge request?

Binaryify commented 5 years ago

yes 😃