search

Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.53k stars 290 forks source link

Organization for grouping OneDarkPro themes #344

Open LukasPolak opened 5 years ago

LukasPolak commented 5 years ago

It is possible to create an organization for grouping OneDarkPro themes (VSC, Slack, Hyper, iTerm, etc.)? I have some themes already done. If you have any questions I'm ready to answer. Thanks

My suggestion is to make an organization OneDarkPro and repo should be e.g. OneDarkPro-VSCode. But this is my personal preference

mskelton commented 5 years ago

I want to be careful in saying this to not come off the wrong way, but this sounds a lot like the flatmap-stream npm package hack. The attacker in that hack started by contributing several legitimate contributions and was made the maintainer of the flatmap-stream packages as the original maintainer was not very active in development of the package. Once he had gained control, he altered the code to steal cryptocurrency.

While this may very well not be the same here, the details reminded me of the flatmap-stream issue like deja vu. @Binaryify I would be very careful with requests like this especially if it involves moving the repo to another organization where you may not be the full admin, etc.

LukasPolak commented 5 years ago

Sorry, if this looks like a "flatmap-stream npm package hack". This is not the purpose of my suggestion. I do not want to be maintainer (be full admin), member role is fine for me. My only aim is to improve the theme and make more themes on the same base. I know that @markypython has a similar organization with themes for JetBrains products and VSC, but I want to build on this repository. Thats it.

mskelton commented 5 years ago

@LukasPolak As I said, I wanted to be careful with how I said it. Please try not to take this as a personal attack, as that was not my goal. My goal was merely to remind us of similar events in the past the ended poorly.

Thanks for clarifying your purpose!