Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Color debug status bar #374

Closed JMS55 closed 4 years ago

Binaryify commented 4 years ago

could you provide more infomation

JMS55 commented 4 years ago

When debugging, the status bar turns purple. Not sure what a better color would be, but I'm not a fan of the purple. image

Binaryify commented 4 years ago

I just change that, you can check it later~

JMS55 commented 4 years ago

Looks good!

tristan957 commented 2 years ago

Hi @Binaryify, I really like the debug status bar color. Something I noticed in a recent debugging session was that hovering status bar elements during a debug session lost the orange color (One Dark Pro Darker). The hover color was the same or nearly the same as the default status bar color.

Happy to try to provide a screenshot if you can't reproduce what I am talking about or don't understand it.

Binaryify commented 2 years ago

@tristan957 are you using flat theme now

tristan957 commented 2 years ago

No, actually my theme is just the plain "One Dark Pro"

Binaryify commented 2 years ago

@tristan957 just fixed that in v3.13.26, you can check it now

skilkis commented 2 years ago

@Binaryify thanks for all of your hard work creating and maintaining One Dark Pro! 🎉 A few years ago I opened the original PR on One Dark Pro Flat #One Dark Pro Flat. Are you open to changing the flat theme debug color back to something that is monochrome? If not, it's not a big deal and I can keep using the previous color by changing my local configuration 😊

skilkis commented 2 years ago

I see now that some changes were incorporated by #726 which removed visual semantics of when the debugger was active

Binaryify commented 2 years ago

@skilkis I think debugging status bar background should be special, if you like the old one, you can just custom it in your setting.json

skilkis commented 2 years ago

@Binaryify I completely agree with you. To clarify what I meant was pre #726 behavior as follows:

image

Indeed I can change it in settings.json 😊

tristan957 commented 2 years ago

@Binaryify I got a picture of what I was talking about. That is me hovering that part of the status bar. image

Binaryify commented 2 years ago

@tristan957 it is a bug, I just delete the statusBarItem.hoverBackground in v3.13.27, and it look normal now image

Binaryify commented 2 years ago

@tristan957 in v3.13.29, it look like this

image image image image