Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Very Low Contrast in comments in compare view (source control) #38

Closed tolu closed 7 years ago

tolu commented 7 years ago

First of all, thanks for an amazing theme!

I'd love to see if it were possible to get a better contrast for diff's in comments.

Here with javascript image

And this is C# image

Comments might not be the most important thing in a compare view but it should at least be possible to see the changes at all 😄

Binaryify commented 7 years ago

Sorry about it, but the comments background color can't change, you can change the theme background
Add this code snippet in your 'settings.json' file

"workbench.experimental.colorCustomizations":{
    "activeTabBackground": "#282c34",
    "activityBarBackground":"#282c34",
    "editorGroupBackground": "#282c34",
    "sideBarBackground": "#282c34",
    "editorBackground": "the background color you want"
  }

If you think the background color is better my background color, you can send a pull request to me, thx ~

tolu commented 7 years ago

thanks for the quick response and the tip!

Binaryify commented 7 years ago

@tolu You can see this issue https://github.com/Binaryify/OneDark-Pro/issues/52#issuecomment-300348666

tolu commented 7 years ago

Fantastic, you made my day, thanks @binaryify!!!

Binaryify commented 7 years ago

@tolu The new feature will come next version, but you can edit the 'setting.json' before the update come