VsCode February 2020 (version 1.43) update broke syntax highlighting

[RadomirPerisic]

https://github.com/microsoft/vscode/issues/92308

I tested on JS only but I read other languages are affected as well.

Temporary fix is to add

"editor.semanticHighlighting.enabled": false

in settings.

With semantic highlighting enabled:

disabled:

[jacobdcastro]

Yeah I'm having the same highlighting problem. Hope it gets fixed soon!

[Binaryify]

should wait vscode fix it and release new version, that option shoule be false default

[RadomirPerisic]

https://github.com/microsoft/vscode/issues/92308#issuecomment-596912859

I think theme needs to be updated to support new identifiers.

[kamenivskyi]

With imports is the same issue (in React)

[Binaryify]

will adapt that in next version, but need some time, so you guy can set it be false, and watiting next version

[jacobdcastro]

@Binaryify thanks so much for the hard work! Huge fan of the theme.

[Binaryify]

https://github.com/microsoft/vscode/wiki/Semantic-Highlighting-Overview#as-a-theme-author-do-i-need-to-change-my-theme-to-make-it-work-with-semantic-highlighting look like vscode will fix this in 1.43.1

[Pandawan]

Great! So will there be a future update that makes use of this semantic highlighting? Theme works fine without it so imo it’s not necessary, but maybe others think differently?

[Binaryify]

@PandawanFr I think it’s not necessary, and I just try to adapt that and found that will make some breaking change

[mrmckeb]

Does this mean the theme doesn't need changes to support "semantic highlighting"?

[Binaryify]

@mrmckeb I think it doesn't need

[mrmckeb]

This is how highlighting looks in the default Dark theme:

And the same file in OneDark Pro:

Maybe it needs a little tweaking?

[Binaryify]

@mrmckeb i don't think it need and the default dark theme use semantic highlighting but other theme will ignore semantic highlighting after vscode update