Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Markdown preview color matching #388

Closed liuzhihang closed 4 years ago

liuzhihang commented 4 years ago

Regarding whether the color style can use the atom style in the markdown preview.

Because I found that the color matching of the code block during the preview, the title color matching is not the style of the atom used.

If you can achieve markdown preview using other styles in other ways, please let me know.

Binaryify commented 4 years ago

I don't know how to change that, vscode doesn't provide that way

Binaryify commented 4 years ago

well, I just found a way to change code color in markdown preview, might update in few days

Binaryify commented 4 years ago

just support that and release a new version, you can check it now, but for the webview limit reason, can't highlight some token

al2me6 commented 4 years ago

Hmm, it seems like the css files added in 4c2d1c114ce7060fb93ef6b784c656739f991958 are enabled even if One Dark Pro is not used as the current editor themes. This is causing breakage in other themes:

image

Binaryify commented 4 years ago

@al2me6 oh, i didn't realized that, will fixed that

liuzhihang commented 4 years ago

@Binaryify Thanks Reply。

I also found that some styles are different,but now it is much better than before, thank you very much.

`code`

### title

> quote

Atom style

image

Some colors have different styles. The whole is already very good, especially the table function.

Special thanks, very good.

Binaryify commented 4 years ago

@al2me6 just release a new version and limit only active in dark theme, still need to find a way to limit in this theme

Binaryify commented 4 years ago

@liuzhihangs will improve that in next version

Binaryify commented 4 years ago

I just revert that change in v3.6 for some bug reason, but you could add this into your setting.json

"markdown.styles": [
       "https://cdn.jsdelivr.net/gh/Binaryify/OneDark-Pro/styles/base.css",
       "https://cdn.jsdelivr.net/gh/Binaryify/OneDark-Pro/styles/markdown.css",
       "https://cdn.jsdelivr.net/gh/Binaryify/OneDark-Pro/styles/atom-one-dark.css"
    ],
Binaryify commented 4 years ago

@liuzhihangs I just update the markdown css, you could check if it fine (please use jsdelivr cdn link now, the css can't be integrated into this extensions temporarily or it will impact on other themes, I also create this issue https://github.com/microsoft/vscode/issues/97663)

liuzhihang commented 4 years ago

@Binaryify Thanks, it's okay now.

Binaryify commented 4 years ago

you don't need to set markdown.styles now in new version

liuzhihang commented 4 years ago

you don't need to set markdown.styles now in new version

Very good, thank you very much.