Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Question: custom colors #43

Closed santekotturi closed 7 years ago

santekotturi commented 7 years ago

In Javascript, I'd like my local variables (declared with let const var) to be a different color than function parameters. I've looked through the .tmTheme source and am not exactly sure what I'm looking for.

function(foo) {
   var bar = 'local variable';
   console.log(foo + bar);        // where foo & bar would be different colors, say bar is default red, and foo is maybe purple or something..
}

is it possible to override with some custom settings for this kind of thing or would I need to fork, change & install?

santekotturi commented 7 years ago

Seems like a related request: https://github.com/Microsoft/vscode/issues/11556

Perhaps its not possible atm?

Binaryify commented 7 years ago

You can see https://binaryify.github.io/OneDark-Pro/#/?id=design

Binaryify commented 7 years ago

The 'foo' and the 'bar' has the same scope, so they can't has different color image image

santekotturi commented 7 years ago

Damn, local vs global vs parameter distinction was suppose useful in WebStorm. Thanks for helping me understand the underlying constraint!

I'm not fully abreast with vscode future enhancements, is this a kind of thing that could be implemented in the future or with the move more towards TS, is this something that TS specific themes would be able to handle?

jens1o commented 7 years ago

You should ask in vscode's repository and ask wether they can improve the grammar, so it matches your case.