search

Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Operator Mono Italic Support? #48

Closed brentluna closed 7 years ago

brentluna commented 7 years ago

Any chance to add support for italics on keywords and the like, similar to Dracula and Panda Syntax Themes?

Thanks and keep up the good work!

Binaryify commented 7 years ago

Can you provide some screenshot ?

brentluna commented 7 years ago

screen shot 2017-05-09 at 10 58 09 am screen shot 2017-05-09 at 10 57 47 am

Here are the repos for those screenshots. I think Panda goes a bit overboard by italicizing a bit too much, while Dracula could probably add a few more keywords to what is italic.

https://github.com/tinkertrain/panda-syntax-vscode https://github.com/dracula/visual-studio-code

will-stone commented 7 years ago

This request isn't really in line with Atom's One Dark theme, and may not be in favour of those that have come here in search of that. @brentluna I'd suggest forking this theme if you'd like a variation of it.

Binaryify commented 7 years ago

@brentluna You can see this REPO https://github.com/tonsky/FiraCode/wiki I try brew tap caskroom/fonts and brew cask install font-fira-code and change setting.json like this

"editor.fontFamily": "Fira Code",
"editor.fontLigatures": true,

image and the result like this image

DenisValcke commented 7 years ago

I see this one is closed but I tried it and there are no italic keywords in both HTML or JS files. Does this mean this is not going to get supported in this theme? In "An Old Hope with italics":

schermafbeelding 2017-05-18 om 12 41 56

In "One Dark Pro":

schermafbeelding 2017-05-18 om 12 42 15

If this feature might come to this theme that would be awesome as it really increases legibility imo.

Binaryify commented 7 years ago

Oh I misunderstand you mean

Binaryify commented 7 years ago

Will add this feature

jens1o commented 7 years ago

well, I'm fine with the current situation :/

Binaryify commented 7 years ago

Will look like this image

jens1o commented 7 years ago

Okay, I'm fine with it.

Binaryify commented 7 years ago

Done

rafaberaldo commented 7 years ago

Any way to disable it? I'm not a fan.

jens1o commented 7 years ago

Well, unfortunately no. Maybe @Binaryify wants to create 2 versions of this(Extensions can ship more than one theme) whereas one is with italic and one isn't?

Binaryify commented 7 years ago

@rafaelpimpa You can see this https://github.com/Binaryify/OneDark-Pro/issues/70