Open mcanepa opened 3 years ago
This is the test file...
BaseObject.Some.Path.ToClass = {}
BaseObject.Some.Path.ALLCAPS = {}
BaseObject.Some.Path.ToClass = class extends SomeParentClass
{
constructor(parameter)
{
super();
this.param = parameter;
var my_var = true;
if($(parameter).hasClass("my_class"))
{
$("some_selector").data("my_data", 123);
my_var = !my_var;
}
}
}
class MyClass extends BaseObject.Some.Path.ToClass
{
constructor()
{
super("div");
}
}
var objInstance = new MyClass();
how about this
and I can't let Some.Path
become redish because they had same scope
constructor neither
With this change chains of objects inside class became yellowish. For example:
Previously this
was yellowish, _subscriptionDestroy$
was redish. The last items were blueish as it is right now. Now the whole chain is yellowish except the last item, so for long chains like environment.urls.backoffice.default
it is too much yellow )
BTW, all items in environment.urls.backoffice.default
were redish previously.
One one hand, there are differences between this theme and Atoms' (we previously agreed that they could be kind of different) but there also differences between the theme itself
Here's a sample image...
I think that
BaseObject
shoud be yellowish,ALLCAPS
redish andSome.Path.ToClass
in line 23 redish as the declarationAs a bonus,
constructor()
andsuper()
should be that two shades of blueishWhat do you think?