search

Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Some color issues #55

Closed jackytse closed 7 years ago

jackytse commented 7 years ago

I use the OneDark-Pro v2.7.2, the "titleBar.activeBackground", the "tab.activeBackground" and the "editor.background" are the same, I think that is not good; the "statusBar.background" is not the visual studio classical blue, is there something wrong?

qq20170510-093435

Binaryify commented 7 years ago

It was a new feature https://github.com/Binaryify/OneDark-Pro/pull/45 https://github.com/Binaryify/OneDark-Pro/pull/51 You can update to the latest version v2.7.3, and see if it had improve And you can see this DOCS https://code.visualstudio.com/docs/getstarted/theme-color-reference You can DIY this code include "statusBar.background" to bring it back https://code.visualstudio.com/docs/getstarted/theme-color-reference#_status-bar-colors

jackytse commented 7 years ago

Thanks for your answer, I updated to the 2.7.3, but I don't like this update, because most components's color are the same. I don't think it is a better choice.

Binaryify commented 7 years ago

Everyone's aesthetic is different, so I provide this DOCS to help everyone to DIY https://binaryify.github.io/OneDark-Pro

jackytse commented 7 years ago

I agree with you, everyone's aesthetic is different, you've done very well, thank you.