Closed will-stone closed 3 years ago
Binaryify
commented
3 years ago I don't know those project before this issue, and I have not idea, In a way, Onedark Pro also is a fork of Onedark, and I cannot represent the official of Onedark, but those project should have designed their logo instead of using ours, what do you think
Binaryify
commented
3 years ago about the sponsorship, I think if they do great job, they should get their reward, I don't mind
will-stone
commented
3 years ago If you don't mind, then that's okay. Personally, I would feel a bit irked if someone was making money from a project where they had taken the logo from my project. Part of the fun of making something is creating its identity. I mean, it's not like it took me long to make a purple atom on a dark background for the OneDark Pro logo ๐ Just a small change is sufficient. Here's a great example of "just make it slightly different" has worked well: https://marketplace.visualstudio.com/items?itemName=Wendell.atom-one-dark-theme-underlined#review-details You immediately know what is going on: same great theme that you like, but with more underlines ๐ So, if it were me, I would tag all the authors of these themes and ask them politely to start their own identity, but I understand if you'd rather leave it.
Binaryify
commented
3 years ago yes, at least they should make the logo slightly different
will-stone
commented
3 years ago Hi @maykefreitas, @eserozvataf, @ratul-devR, @mskelton, @thaintp,
Thank you for taking inspiration from this project, however, the logo you are currently using for your One Dark theme is associated with this project only. By copying the branding from this project, you may be inadvertently confusing people who are looking for this theme. Therefore, we respectively ask that you update your logos so that they are distinguishable from this project.
Some quick suggestions:
I'm also happy to help you design a new and unique logo for your project.
Thank you for your time and understanding.
developeratul
commented
3 years ago Opps! Sorry if it has bothered you.
I am updating it as soon as possible.
And thanks for informing me.
On Mon, May 17, 2021 at 1:35 PM Will Stone @.***> wrote:
Hi @maykefreitas https://github.com/maykefreitas, @eserozvataf https://github.com/eserozvataf, @ratul-devR https://github.com/ratul-devR, @mskelton https://github.com/mskelton, @thaintp https://github.com/thaintp,
Thank you for taking inspiration from this project, however, the logo you are currently using for your One Dark theme is associated with this project only. By copying the branding from this project, you may be inadvertently confusing people who are looking for this theme. Therefore, we respectively ask that you update your logos so that they are distinguishable from this project.
Some quick suggestions:
- Invert the colours of OneDark-Pro's logo.
- Use a different OneDark syntax colour for the atom.
I'm also happy to help you design a new and unique logo for your project.
Thank you for your time and understanding.
โ You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Binaryify/OneDark-Pro/issues/550#issuecomment-842086755, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARB557QEWLQ7MYCLZ2R4HW3TODBNDANCNFSM442TP6PQ .
-- devR Full Stack Javascript Developer
will-stone
commented
3 years ago Thank you @ratul-devR, much appreciated ๐
sudomf
commented
3 years ago hey @will-stone thanks for informing me. I'll update my theme logo ASAP.
will-stone
commented
3 years ago Thanks @maykefreitas. I'm looking forward to seeing all the new logos ๐ค
sudomf
commented
3 years ago 
sudomf
commented
3 years ago @will-stone please let me know if it's ok now.
will-stone
commented
3 years ago @maykefreitas To be honest, it looks like youโre being a bit of a troll. Was that your intention? If not, I do apologise. Would you like some help creating your own brand? I thought of a great, simple alternative: use a purple โ1โ in the circle, instead of the atom. Please note, Iโm not prescribing anything, have fun with your own identity.
mskelton
commented
3 years ago @will-stone I appreciate you bringing up this issue as it certainly can cause confusion. I'm the maintainer of the One Dark org and I have a few thoughts to share on the issue if you don't mind ๐
Have these projects contacted you for permission to use it?
This project is MIT licensed, so permissions isn't really required for much if anything. That said, you make a good point regarding identify not being part of licensing, though I wonder to what extent identity applies? Does it apply to all identifications? Or does it really only apply to trademarks, business names, etc. none of which apply to this project if I am not mistaken. I'm not a lawyer so I'm not really sure how licensing works to any great extent, so any help understanding is definitely appreciated.
However, some are using it for financial gain, which is at least morally suspect.
This is an interesting point and one I take significant disagreement with. Those who are receiving financial gain from a theme whether through required payment (as is the case for Atom One Dark By Mayke) or sponsorships (which is the case for my theme) has little to do with the logo and much more to do with the actual product. People aren't downloading it because they like the logo, but rather because they like the theme. Furthermore, since you can't really search for logos on either the VS Code or JetBrains marketplace, they are likely finding the theme by searing for "one dark" or some similar search query. Now, if someone took this entire repo and made a paid version, that is definitely getting into the morally suspect realm, though still seems perfectly valid given the MIT license which is basically: "do whatever you want with it".
While on this subject, I should mention that in late 2019, the author of this repository made a major update by essentially just copied my repo (https://github.com/one-dark/vscode-one-dark-theme) which I had rebuilt from the ground up (originally my repo was a fork which I had made a bunch of changes to), made some improvements upon it, and published v3 of this theme without any attribution to me for my work whatsoever. The original commit can be seen here: https://github.com/Binaryify/OneDark-Pro/commit/57bb08a3d9110c0d6991c989a561215c06b5312b.
Now, I don't mention this out of spite. Rather to demonstrate how MIT licensing works. I published my repo under MIT licensing, the author of this repo saw and liked it, and updated to use the concept I developed. And like me, he also accepts financial contributions for this theme. So, if using someone else's open source work for financial gain is the issue, there is a bit of a two way street going on here.
But, let me reiterate in saying this is not a problem. I published my code under MIT so the author of this repo had complete right in doing what he did. While I would have appreciated an attribute for my work, it isn't required under MIT.
I'm also happy to help you design a new and unique logo for your project.
Okay, time to bring my comment to a conclusion and explain where I'm at with this. First of all, I think that rebranding these projects (regardless of if there is a specific legal requirement) is a good change. Allowing each to establish their identity benefits not only One Dark Pro, but also the rest of us maintains who have separate projects. Second, I greatly appreciate your willingness to help us with redesigning our logos, and I would actually love to take you up on your offer given I'm not good with logos ๐ When I started down the journey of one dark themes, it was some small tweaks in a fork so the logo was the same. Now, 3 or 4 years later I'm maintaining a GitHub org with themes containing millions of downloads so yeah, probably time for a unique logo ๐
I guess my point in this entire comment is not to argue or disagree with your proposal since I think it is a good proposal. Rather, I wanted to bring some more viewpoints to the discussion. Hope this all makes sense, if not, I'm happy to elaborate!
Cheers!
sudomf
commented
3 years ago @maykefreitas To be honest, it looks like youโre being a bit of a troll. Was that your intention? If not, I do apologise. Would you like some help creating your own brand? I thought of a great, simple alternative: use a purple โ1โ in the circle, instead of the atom. Please note, Iโm not prescribing anything, have fun with your own identity.
No @will-stone I'm not trying to be a troll and I don't think "morally suspect" is the best term for what I'm doing. I'm genuinely selling my theme which was free for 2 years with ZERO donations and now people who really like the theme are paying for that, I don't see any problem about it. I used that logo 2 years ago when I started developing my theme cause I thought it was the official One Dark logo, and now, I'm just trying to make it different from this repo's logo as @mskelton suggested above, without making a huge change on the logo to prevent my old users from misidentifying my theme on Jetbrains Marketplace.
@mskelton thanks a lot for the clarifications, I totally agree with "People aren't downloading it because they like the logo, but rather because they like the theme" but I would ask @Binaryify to please validate if my new logo with that little change can be used or not, cause I don't want to make a big impact coming with a totally different logo right now. Thanks a lot, and congrats on your original work :)
sudomf
commented
3 years ago @Binaryify I think you should say yes or not to the changes, if you say I need to change my logo, I'll totally respect it.
will-stone
commented
3 years ago @mskelton Good points, well made (and I wasn't aware of the history ๐ฌ only that this was the theme I chose when I moved from Atom and so made the logo for it). I'm happy to help out. Let's start a logo issue on your repo and I'll submit some ideas. Thanks.
@maykefreitas This is how it feels: you've opened Paint, selected green, and clicked once on the image. As for selling your theme, of course that's the correct thing to do if you want people to support your work and your chosen marketplace supports adding monetary values to themes. However, you've copied the logo from another IDE theme, that is incredibly popular, and so people searching for OneDark may believe that it's supported by the same author. As @mskelton points out, you're under no obligation to change it, this is just a polite request. Therefore we leave it down to you as to what you feel is right.
sudomf
commented
3 years ago @will-stone Is Paint supporting SVG? I don't use it since I was a kid. I have used Illustrator just FYI. Here is my new logo, it's similar just in the background circle (I hope it's ok), but not colors, symbol, or anything else similar right now. I don't want to be seen as a logo thief for any reason.
https://plugins.jetbrains.com/plugin/13016-atom-one-dark-by-mayke
mskelton
commented
3 years ago So, just to add some more interesting information to this conversation, the argument about identity could in some ways be used for this theme as well given that the logo is a direct copy of the Atom text editor logo with the slight color change. Again, I'm not arguing that changing the logos isn't a good change, but perhaps if other maintainers are expected to do so, maybe this theme could lead by example? ๐คท
will-stone
commented
3 years ago Yes @mskelton I made it a long time ago when re-colouring an existing logo was just about all I was capable of achieving ๐ Also the logo was supposed to be for the Atom nomads. I doubt that's still as prevalent a concern these days.
Hey @Binaryify do you fancy this one? Make yours stand-out from the rest ๐
Binaryify
commented
3 years ago @will-stone that would make confusing, we should keep the shape and the color, and add some embellishments or distortions, and the logo now is good enough and it looks distinctly different from the official one, I don't think need change๏ผwhat do you think
will-stone
commented
3 years ago Sure. I'm going to stay out of it now and close this issue. I really enjoy uniquely branding my projects, but this sentiment doesn't seem to be shared. I apologise if I've caused anybody irritation. If anyone has a new project that is logo-less, feel free to contact me if you'd like help with a logo.
Binaryify
commented
3 years ago @will-stone it's fine, and I really like the logo you made for this theme~ I just think we should keep this logo and wish other theme use their logo
Hi @Binaryify,
I'm starting to see more and more projects pop-up that are using OneDark Pro's logo. Have these projects contacted you for permission to use it?
It's nice that people think the logo is the "official identifier" for any OneDark theme. However, some are using it for financial gain, which is at least morally suspect. OpenSource.org gives the impression that identity is not something that is considered permissive.
Shall we gently nudge these projects to establish their own branding?